Missing logic

[vbaidak]

closes #45

[Copilot]

Pull request overview

Implements the missing pieces requested in issue #45 by expanding the System role (locales/scripts/services), standardizing templates to .j2, and extending the SSL/Docker roles to support client cert generation and Docker daemon configuration (TLS/QEMU), with corresponding Molecule coverage and a version bump.

Changes:

• Add system locales support (Debian + RedHat), generalized script deployment, and service management.
• Add SSL client certificate generation and Docker daemon/systemd configuration (including optional QEMU/binfmt setup).
• Standardize template filenames to .j2, update Molecule verifications, bump collection version and changelog.

Reviewed changes

Copilot reviewed 53 out of 71 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
roles/system/templates/motd.j2	Add MOTD template with contacts
roles/system/tasks/system.yml	Include locales/services tasks
roles/system/tasks/services.yml	Add systemd-based service management
roles/system/tasks/scripts.yml	Generalize script deployment loop
roles/system/tasks/redhat/locales.yml	Implement RedHat locales setup
roles/system/tasks/main.yml	Expand container virtualization detection
roles/system/tasks/locales.yml	Dispatch locales per OS family
roles/system/tasks/debian/locales.yml	Implement Debian locales setup
roles/system/README.md	Document new system variables/features
roles/system/defaults/main.yml	Add defaults for locales/scripts/services; motd.j2 default
roles/ssl/tasks/setup.yml	Create client key/cert directories
roles/ssl/tasks/main.yml	Include SSL client generation tasks
roles/ssl/tasks/clients.yml	Generate client keys/CSRs/certs
roles/ssl/README.md	Document SSL client support + dirs
roles/ssl/defaults/main.yml	Add defaults for client key/cert locations
roles/samba/templates/smb.conf.j2	Add Samba config template (.j2)
roles/samba/tasks/samba.yml	Update template source to smb.conf.j2
roles/packages/templates/.bash_aliases.j2	Escape single quotes in alias commands + spacing
roles/packages/tasks/bash.yml	Update template source to .bash_aliases.j2
roles/nut/templates/upsset.conf.j2	Add NUT CGI config template
roles/nut/templates/upssched.conf.j2	Add upssched configuration template
roles/nut/templates/upssched-cmd.j2	Add upssched command script template
roles/nut/templates/upsmon.conf.j2	Add upsmon configuration template
roles/nut/templates/upsd.users.j2	Add upsd users template
roles/nut/templates/upsd.conf.j2	Add upsd configuration template
roles/nut/templates/ups.conf.j2	Add ups.conf template
roles/nut/templates/ups-update-variable.j2	Add helper script template for UPS variable updates
roles/nut/templates/nut.conf.j2	Add nut.conf template
roles/nut/templates/hosts.conf.j2	Add NUT CGI hosts.conf template
roles/nut/tasks/upssched.yml	Use .j2 template sources
roles/nut/tasks/upsmon.yml	Use .j2 template source
roles/nut/tasks/upsd.yml	Use .j2 template sources + strip .j2 in dest
roles/nut/tasks/ups.yml	Use .j2 template source
roles/nut/tasks/ups_vars.yml	Use .j2 template source
roles/nut/tasks/nut.yml	Use .j2 template source
roles/nut/tasks/cgi.yml	Use .j2 template sources + strip .j2 in dest
roles/mail/templates/redhat/sasl_passwd.j2	Add Postfix sasl_passwd template
roles/mail/templates/redhat/main.cf.j2	Add Postfix main.cf template
roles/mail/templates/debian/update-exim4.conf.conf.j2	Add Exim update-exim4.conf.conf template
roles/mail/templates/debian/passwd.client.j2	Add Exim passwd.client template
roles/mail/templates/debian/99_exim4-config_rewrite_rules.j2	Add Exim rewrite rules template
roles/mail/tasks/redhat/mail.yml	Point tasks to .j2 templates
roles/mail/tasks/debian/mail.yml	Point tasks to .j2 templates
roles/fs/templates/auto-remount.j2	Add auto-remount script template (.j2)
roles/fs/tasks/mount.yml	Update template source to auto-remount.j2
roles/docker/vars/main.yml	Add docker vars (override dir/default host)
roles/docker/templates/daemon.json.j2	Add daemon.json template (hosts/TLS)
roles/docker/tasks/setup.yml	Deploy systemd override + daemon.json
roles/docker/tasks/qemu.yml	Add optional QEMU/binfmt setup
roles/docker/tasks/main.yml	Include qemu tasks when enabled
roles/docker/README.md	Document new Docker variables/features
roles/docker/meta/main.yml	Add dependency on scalified.setup.ssl
roles/docker/files/override.conf	Add docker systemd drop-in override
roles/docker/defaults/main.yml	Add defaults for hosts/TLS/qemu
molecule/default/roles/system/tasks/scripts.yml	Verify custom scripts deployment
molecule/default/roles/system/tasks/redhat/locales.yml	Verify RedHat locales behavior
molecule/default/roles/system/tasks/main.yml	Include locales verifications
molecule/default/roles/system/tasks/locales.yml	Verify generated locales
molecule/default/roles/system/tasks/debian/locales.yml	Verify Debian locales behavior
molecule/default/roles/system/files/system-test-script	Add test script fixture
molecule/default/roles/ssl/vars/main.yml	Adjust molecule ssl vars
molecule/default/roles/ssl/tasks/main.yml	Add SSL client verifications
molecule/default/roles/ssl/tasks/client.yml	Verify generated client certs/keys
molecule/default/roles/ssl/defaults/main.yml	Adjust molecule ssl defaults
molecule/default/roles/packages/tasks/bash.yml	Validate aliases spacing + bash syntax
molecule/default/roles/docker/tasks/setup.yml	Verify docker override + TLS config
molecule/default/group_vars/all.yml	Set molecule variables for new features
galaxy.yml	Bump collection version to 2.8.0
CHANGELOG.md	Add 2.8.0 changelog entry
.github/workflows/publish.yml	Update checkout action version
.github/workflows/build.yml	Update checkout + ansible-lint action versions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.