Skip to content

Split MySQL pages to follow what's been done for PG #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 22, 2025
Merged

Split MySQL pages to follow what's been done for PG #3092

merged 8 commits into from
Apr 22, 2025

Conversation

Frzk
Copy link
Contributor

@Frzk Frzk commented Mar 27, 2025

Replace the "Managing" page with:

  • a "Managing Users" page
  • a "Changing Plan" page
  • a "Upgrading" page
  • a "Working with SQL Modes" page
  • a "Using Multiple Databases" page.

@Frzk Frzk self-assigned this Mar 27, 2025
@Frzk Frzk marked this pull request as ready for review March 31, 2025 15:08
@Frzk Frzk requested a review from curzolapierre April 11, 2025 09:17
curzolapierre
curzolapierre requested changes Apr 22, 2025
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this changes! Some links are broken but overall it's LGTM

Frzk and others added 2 commits April 22, 2025 11:57
@Frzk
Copy link
Contributor Author

Frzk commented Apr 22, 2025

Thanks a lot for the review @curzolapierre and sorry for the links 😞

As you can see, I still have one more question to figure out 😬, the rest should be fixed.

@Frzk Frzk requested a review from curzolapierre April 22, 2025 10:18
@Frzk Frzk merged commit 724afbc into master Apr 22, 2025
4 checks passed
@Frzk Frzk deleted the chore/databases/mysql branch April 22, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminach benjaminach benjaminach approved these changes

@curzolapierre curzolapierre curzolapierre approved these changes

@EtienneM EtienneM Awaiting requested review from EtienneM

@brandon-welsch brandon-welsch Awaiting requested review from brandon-welsch

Assignees

@Frzk Frzk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frzk @benjaminach @curzolapierre