feat: accept € amounts, nudge bare integers instead of silence - #4
Merged
Conversation
- 50€ Pizza / €50 / € 50,50 / 50.00€ / €12,30 all record — a currency symbol on either side makes the intent unambiguous, so integers are ok - bare integers (50 Pizza) nudge instead of staying silent; accepted tradeoff: '2 Minuten bin ich da' now draws the nudge too (it still never records) - unified nudge text teaches the format instead of the misleading 'expenses start with the amount' Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three usage bugs:
50€ Pizza,50 € Pizza,€50 Pizza,€ 50,50 X, and decimals+currency (50.00€ Rewe,€12,30 Drogerie) all record. € on either side makes the intent unambiguous, so bare integers with € are accepted.50 Pizza) nudge instead of silence — decided tradeoff:2 Minuten bin ich dahas the same shape and now draws one nudge too (it still never records, preserving the CLAUDE.md invariant).50.00€ Rewedid).Full trigger/nudge/silent matrix covered in
parse-msg-accepts-currency-symbol+ updated loud-failure tests; € never leaks into descriptions. CONTRACT.md updated. 53 tests / 191 assertions green under bb and JVM.🤖 Generated with Claude Code