-
Notifications
You must be signed in to change notification settings - Fork 33
feat: make configurable action buttons shared component #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to SWAP-4889-configurable-action-buttons
…b.com/SciCatProject/frontend into SWAP-4889-configurable-action-buttons
|
Hi, two points I noticed while testing:
In general, would it make sense to unify the different methods a little bit? Building the info as an object in a shared way and then transforming it into json/the form etc? I tested it when the PR was at |
…b.com/SciCatProject/frontend into SWAP-4889-configurable-action-buttons
…b.com/SciCatProject/frontend into SWAP-4889-configurable-action-buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New security issues found
…b.com/SciCatProject/frontend into SWAP-4889-configurable-action-buttons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New security issues found
Description
This PR refactors the datafiles action as a configurable components that can be used in other pages of the app.
The configuration has been updated to make the configurable actions more flexible.
Motivation
Up to this point, SciCat had only configurable actions for the data files associated to each dataset.
In the last year, it have become clear that we need to expand this concept also to dataset as a whole, the datasets list, all the way to the selection.
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
Backend version
Summary by Sourcery
Extract datafiles action buttons into a shared, configurable component and remove the legacy dataset-specific implementations
New Features:
Enhancements:
Tests:
Chores:
Summary by Sourcery
Introduce a reusable configurable action buttons component and migrate the existing datafiles actions to use it, generalize action settings in the app config, and clean up the legacy implementations. Also add a suite of shared dataset filter components and update tests accordingly.
New Features:
Enhancements:
Tests:
Chores: