CSV file upload #15
Open
CSV file upload #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgraded to trixie (debian) transitional package deprecated
NXXR
commented
Sep 15, 2025
remove leftover debug code, and linter fixes that don"t belong to this PR
NXXR
commented
Sep 18, 2025
Kanakanajm
reviewed
Sep 29, 2025
| # Validation successful, upload to minio bucket | ||
| lha_id: str = request_state.realm | ||
| # Get lha display name | ||
| lha_name = next((realm['displayName'] for realm in get_realms() if realm['realm'] == lha_id), '') |
There was a problem hiding this comment.
The realm field is explicit enough because it contains the region name (e.g. lha-koeln). The id field consists of the actual UUID used in Keycloak instead. Is it really necessary to include the full name of the LHA?
There was a problem hiding this comment.
Hmm
I'm not sure.
I'll check with Mariama to figure out if the realm field is sufficient.
If they need the exact name they probably could look it up themselves from the api 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds an endpoint where a csv case data file can be uploaded.
It is then validated and forwarded to the rest of the memilio infrastructure.
Also adds IAM endpoints to the
.env.templateinstead of hard-coding them.