Bump compat for OrdinaryDiffEq v7 / SciMLBase v3 ecosystem#43
Open
ChrisRackauckas-Claude wants to merge 3 commits into
Open
Bump compat for OrdinaryDiffEq v7 / SciMLBase v3 ecosystem#43ChrisRackauckas-Claude wants to merge 3 commits into
ChrisRackauckas-Claude wants to merge 3 commits into
Conversation
- DiffEqBase: "6" → "6, 7" (DiffEqBase v7 ships as sublibrary in OrdinaryDiffEq v7 monorepo) - OrdinaryDiffEq: add compat "6, 7" (was in [extras]/[targets] but lacked explicit compat bound) - Catalyst: "15" → "14, 15, 16" (allow v16 which is current) - SteadyStateDiffEq: add compat "1, 2" (was in test deps without compat bound) - Sundials: add compat "4, 5, 6" (was in test deps without compat bound) No source code changes needed: the codebase uses only DiffEqBase APIs (ODEProblem, SteadyStateProblem, ODEFunction, NullParameters) that are unchanged in v7, and tests already use the forward-compatible sol.u[i] indexing (not sol[i]) required by RecursiveArrayTools v4. Refs: SciML/OrdinaryDiffEq.jl#3562, SciML/OrdinaryDiffEq.jl#3565 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Catalyst v16 dropped the ModelingToolkit re-export in favor of ModelingToolkitBase, which broke calls to ModelingToolkit.value, ModelingToolkit.scalarize and ModelingToolkit.varmap_to_vars in src/indexhandlers.jl and src/fspsystem.jl. Migrating to Catalyst v16 is out of scope for this OrdinaryDiffEq v7 ecosystem bump; revert that compat change and leave Catalyst at "15". Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
CI Status Updaterunic / format-check: PASS The CI test failure is Verified the same failure occurred on:
This PR only changes Fixing the pre-existing 🤖 Generated with Claude Code |
Julia 1.12 removed the `mt` field from `Base.MethodList`, breaking `MacroTools.prettify`'s `unresolve` step (FluxML/MacroTools.jl#216). The fix on MacroTools master is unreleased, so define a local `_prettify` that mirrors `MacroTools.prettify` but uses `nameof(f)` on Julia 1.12+ instead of `methods(f).mt.name`. Use it in place of `MacroTools.prettify` in `build_rhs_ex` and `build_rhs_ex_ss`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the compat bounds in
Project.tomlto allow use of the OrdinaryDiffEq v7 / SciMLBase v3 ecosystem introduced in SciML/OrdinaryDiffEq.jl#3562 and SciML/OrdinaryDiffEq.jl#3565.Changes to
[compat]DiffEqBase"6""6, 7"OrdinaryDiffEq"6, 7"[extras]/[targets]but lacked an explicit compat boundCatalyst"15""14, 15, 16"SteadyStateDiffEq"1, 2"Sundials"4, 5, 6"No source code changes needed
The codebase only uses stable DiffEqBase APIs (
ODEProblem,SteadyStateProblem,ODEFunction,NullParameters) that are unchanged in v7. The tests already use the forward-compatiblesol.u[i]indexing (notsol[i]) required by RecursiveArrayTools v4.References
🤖 Generated with Claude Code