Downgrade: raise Reexport compat floor to 1.2.2#57
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Downgrade: raise Reexport compat floor to 1.2.2#57ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
…le at downgrade minimum) At the downgrade minimum, SciMLBase is pinned to its 2.84.0 floor, which caps OrdinaryDiffEqLinear to <=1.4.0. OrdinaryDiffEqLinear 1.1-1.4 require Reexport >= 1.2.2, but the old floor Reexport = "1" let the resolver lock Reexport at 1.2.0, leaving no installable OrdinaryDiffEqLinear -> Unsatisfiable. Reexport 1.2.2 is the smallest version that resolves. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MINIMUM-VERSION downgrade resolve failure
The
Downgradeworkflow fails at thePkg.testre-resolve step (latest failing run 27089954821) with:Conflicting pin / why the old floor was impossible
At the downgrade minimum the resolver pins
SciMLBaseto its 2.84.0 floor. SciMLBase 2.84.0 capsOrdinaryDiffEqLinearto<= 1.4.0, and OrdinaryDiffEqLinear 1.1–1.4 requireReexport = "1.2.2 - 1"(i.e.>= 1.2.2).The old compat
Reexport = "1"let the downgrade manifest lockReexportat 1.2.0, which is< 1.2.2, so no installableOrdinaryDiffEqLinearversion remained → Unsatisfiable. The old floor1.0.0was never co-installable with the package's own OrdinaryDiffEq stack at the downgrade minimum.Fix
Raise the
Reexportfloor to 1.2.2 — the smallest Reexport that OrdinaryDiffEqLinear 1.1–1.4 accept (and the only valid choice given SciMLBase's 2.84.0 floor). This is a lower-bound raise only; no upper bound or test logic changed.Resolve verification (local, Julia 1.10 lts floor)
Reproducing the downgrade re-resolve with
SciMLBase = "=2.84.0":Reexport = "=1.2.0"(old floor's locked minimum) → Unsatisfiable (reproduces CI)Reexport = "=1.2.2"(new floor) → RESOLVE OK (Reexport 1.2.2, OrdinaryDiffEqLinear 1.4.0, SciMLBase 2.84.0)Note: the package's regular (latest-versions) test failure on
mainis a separate, unrelated MacroTools /Base.MethodList.mtissue on Juliapre, not addressed here.This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code