Fix TypeError for nonsquare linear systems with QR factorization #675
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When solving nonsquare linear systems (A*u = b where A is m×n with m≠n), some platforms return QRPivoted with Vector{Int32} for pivot indices from Julia's qr function with ColumnNorm pivot, while LinearSolve's DefaultLinearSolverInit struct expects Vector{Int64}.
Solution
Added a helper function
_ensure_int64_pivot
that converts QRPivoted pivot vectors from Int32 to Int64 when necessary, ensuring compatibility across all platforms.Changes
_ensure_int64_pivot
helper function to convert pivot indices to Int64do_factorization
for QRFactorizationinit_cacheval
functions that return QRPivotedPREALLOCATED_QR_ColumnNorm
uses Int64 pivot indicesTest Plan
Test Results
🤖 Generated with Claude Code