-
-
Notifications
You must be signed in to change notification settings - Fork 224
refactor: format #3710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
refactor: format #3710
Conversation
Formatting failed 😅 |
Yeah, JuliaFormatter v2 doesn't like |
Would you prefer I make CI use v1? |
No we should update to v2. We should just change the code to make it happy then. |
I'll see if I can figure out what it is unhappy about. The error message is incredibly unhelpful. There also doesn't seem to be an option to increase the fixpoint iterations. |
struct Matching{U, V <: AbstractVector} <: AbstractVector{Union{U, Int}} #=> :Unassigned =#
match::V
inv_match::Union{Nothing, V}
end It specifically doesn't like that inline comment. |
just put it above the struct. |
The comment is not very meaningful anyway, and putting it above the struct also fails. I've removed it. This will be a massive PR, unfortunately. |
I'll push the changes, but I find a lot of it pretty questionable |
991655f
to
d07044d
Compare
conflict |
Well yes, but I don't think upgrading to JuliaFormatter@2 is worth it. Most of these changes are nonsensical and worse code quality. |
It's even split multidimensional array indexing into multiple lines in some places for some reason |
Point them all out for @domluna |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.