Skip to content

refactor: format #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

Formatting failed 😅

@AayushSabharwal
Copy link
Member Author

Yeah, JuliaFormatter v2 doesn't like bipartite_graphs.jl for some reason and errors out in CI. This is formatted with v1 locally.

@AayushSabharwal
Copy link
Member Author

Would you prefer I make CI use v1?

@ChrisRackauckas
Copy link
Member

No we should update to v2. We should just change the code to make it happy then.

@AayushSabharwal
Copy link
Member Author

I'll see if I can figure out what it is unhappy about. The error message is incredibly unhelpful. There also doesn't seem to be an option to increase the fixpoint iterations.

@AayushSabharwal
Copy link
Member Author

struct Matching{U, V <: AbstractVector} <: AbstractVector{Union{U, Int}} #=> :Unassigned =#
    match::V
    inv_match::Union{Nothing, V}
end

It specifically doesn't like that inline comment.

@ChrisRackauckas
Copy link
Member

just put it above the struct.

@AayushSabharwal
Copy link
Member Author

@AayushSabharwal
Copy link
Member Author

The comment is not very meaningful anyway, and putting it above the struct also fails. I've removed it. This will be a massive PR, unfortunately.

@AayushSabharwal
Copy link
Member Author

I'll push the changes, but I find a lot of it pretty questionable

@ChrisRackauckas
Copy link
Member

conflict

@AayushSabharwal
Copy link
Member Author

Well yes, but I don't think upgrading to JuliaFormatter@2 is worth it. Most of these changes are nonsensical and worse code quality.

@AayushSabharwal
Copy link
Member Author

It's even split multidimensional array indexing into multiple lines in some places for some reason

@ChrisRackauckas
Copy link
Member

Point them all out for @domluna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants