Skip to content

switch parse_costs! and parse_constraints #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ctessum
Copy link
Contributor

@ctessum ctessum commented Jun 13, 2025

It seems like they are currently backward

It seems like they are currently backward
@ChrisRackauckas
Copy link
Member

@AayushSabharwal better test this?

@AayushSabharwal
Copy link
Member

I'm confused, because we have a test for this and it passes both before and after the swap on CI, but fails after swapping locally.

@AayushSabharwal
Copy link
Member

@ctessum how did you run into this? Are you using MTK.get_gui_metadata?

@ctessum
Copy link
Contributor Author

ctessum commented Jun 13, 2025

I don't have a specific case of it failing, I was just looking through the code and it seemed wrong.

@AayushSabharwal
Copy link
Member

AayushSabharwal commented Jun 13, 2025

I see. So the functions are identical, and because they were passed the correct arrays it worked. i.e. in the @costs case, it called parse_constraints! but passed it the costs array. Constructing the system thus worked fine, it's just that in the Model struct the values are backward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants