-
-
Notifications
You must be signed in to change notification settings - Fork 105
fix isinplace
inference and add inference tests
#1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix isinplace
inference and add inference tests
#1019
Conversation
end | ||
throw(FunctionArgumentsError(fname, f)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message loses a lot of information. Can we in the error path do a method check and throw the more informative error message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the better method is to just put the expected nargs
in the exception and then we can make the exception printing in charge of that logic. That way none of the complicated bits are in the main function.
I just remembered the tricky part here. This query isn't quite right (see JuliaLang/julia#56279 for details):
|
fixes #1017
This also removes
NoMethodsError
,TooManyArgumentsError
, andTooFewArgumentsError
and fixes inference for some*Function
constructors`