Share same cache among similar operators in AddedOperator#370
Open
albertomercurio wants to merge 4 commits intoSciML:masterfrom
Open
Share same cache among similar operators in AddedOperator#370albertomercurio wants to merge 4 commits intoSciML:masterfrom
AddedOperator#370albertomercurio wants to merge 4 commits intoSciML:masterfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
When caching an
AddedOperator, we currently cache all the suboperators iteratively. However, this is suboptimal, as many of them can in principle share the same cache when possible.In this PR I implement this cache sharing in the
AddedOperator. Let's imagine I have the sum ofComposed + Tensor + Tensor + Composed + Matrix + Tensor, many of them require some cache, but they could share the same cache. We can be sure they can share the same cache ifComposedOperator)the first one can be checked even at compile time, while the second requires to define
_get_cache_shapes(op, v), which returns the shape of the cache.Benchmarks
This method allows to save a lot of memory, as also shown in this example