Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed keyword parameters warning with Ruby 2.7 #536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed keyword parameters warning with Ruby 2.7 #536

wants to merge 1 commit into from

Conversation

jonspalmer
Copy link

Cleanup a few more Ruby 2.7 issues similar to #521

Shekharrajak
Shekharrajak approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dvalerojimenez
Copy link

dvalerojimenez commented Nov 6, 2023 •
edited
Loading

I can confirm this as still being a bug in master branch, would be nice to have the patch as Daru::DataFrame.write_csv is broken.

It could also solve the issue with Daru::DataFrame.from_csv: #543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shekharrajak Shekharrajak Shekharrajak approved these changes

Assignees
No one assigned
Labels
can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonspalmer @dvalerojimenez @Shekharrajak