-
Notifications
You must be signed in to change notification settings - Fork 416
May Binary Update #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
May Binary Update #1179
Conversation
Upgraded Linux runners to Ubuntu 24.04
Upgraded Linux AVX512 to Ubuntu 24
…port' into update_apr_2025
update gitignore and add missing xml files
@AmSmart looks like there are some installation issues for CI building the Android example. Not sure why they didn't show up before. Shall we just skip building the Android project in CI for now? |
Awesome! I tried to review the code for the MAUI app, but I don't see any logic code. |
@martindevans Probably fastest cause of action to skip. It ultimately depends on the planned release of this PR though. I've checked the errors and the issue is mostly minor, - I just need to set up the JDK so I can resolve it this weekend. Also probably worth splitting out the build for Mobile into a separate job in the unit test workflow file. Things will be more optimal that way. It is worth saying though, that we'll need to stop building the mobile workloads on Linux as .NET doesn't support MAUI on Linux at the moment. All mobile builds can be run in a single run with osx for example. |
I think the best course of action is to skip building Llama.Mobile for the desktop runs and I'll work on a PR to add a separate job that builds the Mobile project. I can work on that this weekend. What do you think? BTW, how do you trigger the unit test runs? They don't seem to autorun when I update my branch. |
@Lyrcaxis The mobile project simply demonstrates success loading of the library. All the other samples in the repo apply to it just the same. It's fairly trivial to update the sample app a Q&A bot if we think that'll be nicer. |
Pushing to this PR auto trigger them. I think that should work in a fork too. You may need to open a PR to your own master branch for the triggers to pick it up. I've just done some work to exclude the mobile work on non-windows platforms, including removing it from the sln altogether. That's fixed Linux and MacOS. However Windows is still broken because it needs the JDK installed. |
Tested on MacOS. My personal opinion is that the Mobile project should be on a different solution. It depends so much on specific SDK and your platform. |
Updated llama.cpp binaries to ceda28ef8e310a8dee60bf275077a3eedae8e36c, compiled with this run.
This PR includes work done by @nipeone in #1138 (adding Linux-ARM64 support) and by @AmSmart in #1130 (adding Android support).
Testing: