Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform linkchecks periodically instead of on PRs #6292

Open
pp-mo opened this issue Jan 20, 2025 · 1 comment
Open

Perform linkchecks periodically instead of on PRs #6292

pp-mo opened this issue Jan 20, 2025 · 1 comment

Comments

@pp-mo
Copy link
Member

pp-mo commented Jan 20, 2025

Linkcheck failures are an annoying to many PRs.
Most linkcheck failures are spurious and transient, and even those which aren't are generally not caused by changes in the PRs which they block.

So I would like to make them a periodic check instead of a PR check.

This leaves the question of how bad it is if you do introduce a new, broken link in a PR -- which is then not picked up until later.
I'd suggest that just isn't much of a problem

@rcomer
Copy link
Member

rcomer commented Jan 20, 2025

See also #4140.

I think if a PR introduces a new link then the reviewer should manually check it. As well as verifying that the link works, we want to know that what’s behind it is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants