Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for saving string stash codes to PP #6289

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Jan 17, 2025

🚀 Pull Request

Description

Closes #6239. String stash codes now "just work".


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (331f012) to head (bc48dc1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6289      +/-   ##
==========================================
- Coverage   89.85%   89.85%   -0.01%     
==========================================
  Files          88       88              
  Lines       23384    23387       +3     
  Branches     4356     4357       +1     
==========================================
+ Hits        21012    21014       +2     
  Misses       1646     1646              
- Partials      726      727       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcomer
Copy link
Member Author

rcomer commented Jan 17, 2025

Ah linkcheck, I have not missed you.

@pp-mo
Copy link
Member

pp-mo commented Jan 20, 2025

Ah linkcheck, I have not missed you.

😞 I think we should remove this from PRs into a periodic check like benchmarks
#6292

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is totally good enough.

I did wonder about replacing arbitrary odd object with string reprs in netcdf save, but I think that is a step too far : STASH is a special recognised attribute name, and we also convert them back on loading, so we can save UM data and re-save correctly as PP fields with the original stashes.
FWIW we should probably so the same for GRIB too, I currently have an issue open about that.

@pp-mo pp-mo merged commit e9d3cfc into SciTools:main Jan 20, 2025
21 checks passed
@rcomer rcomer deleted the pp-stash branch January 20, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String stash code silently ignored on pp-save
2 participants