ruff checks for numpydocs #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5630 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
bjlittle
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
@tkknight Great thanks.
So this is an interim no-op change. You've added Dxxx rules to the .ruff.toml but will only be enabled by removing the pydocstyle category rule "D" ... plus you're working on other pydocstyle rules to address.
I'm totally okay with this 👍
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 13, 2023
* upstream/main: ruff checks for numpydocs (SciTools#5630) Add whatsnew entries (SciTools#5626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Ruff compliant.
Part of #4721
Consult Iris pull request check list