Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff rule D411 compliance. #5657

Merged
merged 3 commits into from
Dec 19, 2023
Merged

ruff rule D411 compliance. #5657

merged 3 commits into from
Dec 19, 2023

Conversation

tkknight
Copy link
Contributor

🚀 Pull Request

Description

PR solely for fixing D411: Missing blank line before section

Continues work of #5625.

I used the noqa directive here as a few of the docstrings contain Attributes: in the docstest content and ruff thinks it is an over indented title, which it is not. This will be a pattern for future docstrings that contains this.


Consult Iris pull request check list

@tkknight tkknight mentioned this pull request Dec 19, 2023
13 tasks
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bf0ea4) 89.69% compared to head (3b333e5) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5657   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjlittle bjlittle merged commit 52fd4ab into SciTools:main Dec 19, 2023
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Dec 20, 2023
* upstream/main:
  ruff rule D411 compliance. (SciTools#5657)
  ruff rule D208 compliance. (SciTools#5656)
tkknight added a commit to tkknight/iris that referenced this pull request Dec 20, 2023
* upstream/main:
  ruff rule D411 compliance. (SciTools#5657)
  ruff rule D208 compliance. (SciTools#5656)
tkknight added a commit to tkknight/iris that referenced this pull request Dec 20, 2023
* upstream/main:
  ruff rule D411 compliance. (SciTools#5657)
  ruff rule D208 compliance. (SciTools#5656)
@tkknight tkknight deleted the ruff6 branch January 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants