Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff compliance for D405 and D407 #5666

Merged
merged 24 commits into from
Jan 2, 2024
Merged

ruff compliance for D405 and D407 #5666

merged 24 commits into from
Jan 2, 2024

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Dec 26, 2023

🚀 Pull Request

Description

PR solely for fixing:

  • D405: Section name should be properly capitalized
  • D407: Missing dashed underline after section

Whilst fixing the docstrings for D407 I noticed it would use two different styles of headings in functions so I fixed all the headings in all files touched, so the PR is a little bigger than planned but the files touched have not grown.

Continues work of #5625.


Consult Iris pull request check list

@tkknight tkknight mentioned this pull request Dec 26, 2023
13 tasks
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41f1107) 89.69% compared to head (92a5cca) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5666   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight marked this pull request as ready for review December 26, 2023 13:49
@tkknight
Copy link
Contributor Author

Ready for review.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Wow. That was hard work for me ... can't imagine what it must have been like on your side 😱

Amazing effort to tidy this up. Just a couple of minor comments to service ... we can hangout and talk it through 👍

lib/iris/_data_manager.py Outdated Show resolved Hide resolved
lib/iris/_concatenate.py Show resolved Hide resolved
lib/iris/_merge.py Show resolved Hide resolved
lib/iris/analysis/_regrid.py Show resolved Hide resolved
lib/iris/analysis/trajectory.py Show resolved Hide resolved
pp-mo
pp-mo previously requested changes Jan 2, 2024
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK lost of small suggestions + comments.
Got as far down as the end of the lib/iris/analysis/stats.py listing.

I definitely went about this the wrong way.

I will finish the job with remaining suggestions on a PR-to-PR branch

lib/iris/_concatenate.py Outdated Show resolved Hide resolved
lib/iris/_concatenate.py Outdated Show resolved Hide resolved
lib/iris/_concatenate.py Outdated Show resolved Hide resolved
lib/iris/_concatenate.py Outdated Show resolved Hide resolved
lib/iris/analysis/stats.py Outdated Show resolved Hide resolved
lib/iris/analysis/cartography.py Outdated Show resolved Hide resolved
lib/iris/analysis/stats.py Outdated Show resolved Hide resolved
lib/iris/analysis/stats.py Outdated Show resolved Hide resolved
lib/iris/analysis/stats.py Outdated Show resolved Hide resolved
@pp-mo pp-mo dismissed their stale review January 2, 2024 16:38

too much overlap with existing discussions + agreed approach

@pp-mo
Copy link
Member

pp-mo commented Jan 2, 2024

General comment : as discussed offline with @bjlittle
My escalating suggestions are getting in the way.
@bjlittle can bank what is here, and I can maybe propose further improvements later.

Please ignore all the noise, I can't find a way to quickly remove all the multiple comments I made 😞

tkknight and others added 3 commits January 2, 2024 16:57
Co-authored-by: Patrick Peglar <[email protected]>
* 'ruff11' of github.com:tkknight/iris:
  Update lib/iris/_concatenate.py
@bjlittle
Copy link
Member

bjlittle commented Jan 2, 2024

@pp-mo Thanks for wading in, but in this case it might have been better touching base with @tkknight (or myself) beforehand.

You weren't to know that @tkknight and I agreed on a strategy over several offline discussion on how to proceed with the ruff adoption for iris, which is happening over the course of many pull-requests.

If you're a gun for hire, then let us know. You're more than welcome to join us help chip away at the mountain of outstanding work to do. Apologies if you lost time and effort on this.

@bjlittle bjlittle merged commit e2e9454 into SciTools:main Jan 2, 2024
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Jan 3, 2024
* main:
  ruff compliance for D106. (SciTools#5676)
  ruff complliance for rule D202. (SciTools#5674)
  nep29 drop numpy 1.22 (SciTools#5668)
  ruff compliance for D404. (SciTools#5671)
  ruff complliance for D406. (SciTools#5670)
  ruff compliance for D405 and D407 (SciTools#5666)
  Various ruff rule compliance (W, CPY, ISC, AIR) (SciTools#5667)
@tkknight tkknight deleted the ruff11 branch January 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants