Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various ruff rule compliance (W, CPY, ISC, AIR) #5667

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

tkknight
Copy link
Contributor

🚀 Pull Request

Description

PR solely for fixing:

  • pycodestyle (W) - This is the only one that needed a code change.
  • flake8-copyright (CPY)
  • flake8-implicit-str-concat (ISC)
  • Airflow (AIR)

Continues work of #5625.


Consult Iris pull request check list

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b61529) 89.69% compared to head (4eff6fa) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5667   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight tkknight marked this pull request as ready for review December 30, 2023 16:16
@bjlittle bjlittle self-assigned this Jan 2, 2024
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkknight Awesome, thanks 👍

@bjlittle bjlittle merged commit 41f1107 into SciTools:main Jan 2, 2024
17 checks passed
@tkknight tkknight deleted the ruff20 branch January 2, 2024 09:33
tkknight added a commit to tkknight/iris that referenced this pull request Jan 3, 2024
* main:
  ruff compliance for D106. (SciTools#5676)
  ruff complliance for rule D202. (SciTools#5674)
  nep29 drop numpy 1.22 (SciTools#5668)
  ruff compliance for D404. (SciTools#5671)
  ruff complliance for D406. (SciTools#5670)
  ruff compliance for D405 and D407 (SciTools#5666)
  Various ruff rule compliance (W, CPY, ISC, AIR) (SciTools#5667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants