perf(search) free money, a.k.a. fast fail

ScoopInstaller · Feb 10, 2025 · fd1a618 · fd1a618
1 parent ac6f1ba
commit fd1a618
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/libexec/scoop-search.ps1 b/libexec/scoop-search.ps1
@@ -93,7 +93,9 @@ function search_bucket_legacy($bucket, $query) {
     $apps = Get-ChildItem (Find-BucketDirectory $bucket) -Filter '*.json' -Recurse
 
     $apps | ForEach-Object {
-        $manifest = [System.IO.File]::ReadAllText($_.FullName) | ConvertFrom-Json -ErrorAction Continue
+        $content = [System.IO.File]::ReadAllText($_.FullName)
+        if ($content -notmatch $query) { return }
+        $manifest = ConvertFrom-Json $content -ErrorAction Continue
         $name = $_.BaseName
 
         if ($name -match $query) {
@@ -176,14 +178,9 @@ if (get_config USE_SQLITE_CACHE) {
         abort "Invalid regular expression: $($_.Exception.InnerException.Message)"
     }
 
-    $jsonTextAvailable = [System.AppDomain]::CurrentDomain.GetAssemblies() | Where-Object { [System.IO.Path]::GetFileNameWithoutExtension($_.Location) -eq 'System.Text.Json' }
 
     Get-LocalBucket | ForEach-Object {
-        if ($jsonTextAvailable) {
-            search_bucket $_ $query
-        } else {
-            search_bucket_legacy $_ $query
-        }
+        search_bucket_legacy $_ $query
     }
 }