Another attempt to improve the search performance #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
This reverts commit d3d6b01.
|
See conversation in #5324 |
5 tasks
|
would love to see this merged as this drastically reduces search time 👍 |
3 tasks
rashil2000
previously approved these changes
Oct 2, 2023
|
@r15ch13 LGTM - just one small hitch - this is not a bug fix but a performance improvement (in the Changelog) |
CrendKing
pushed a commit
to CrendKing/Scoop
that referenced
this pull request
Oct 3, 2023
…ler#5644) * perf(search): improve local search performance * Update libexec/scoop-search.ps1 Co-authored-by: Hsiao-nan Cheung <[email protected]> * Update libexec/scoop-search.ps1 Co-authored-by: Hsiao-nan Cheung <[email protected]> * Update libexec/scoop-search.ps1 Co-authored-by: Hsiao-nan Cheung <[email protected]> * Update libexec/scoop-search.ps1 Co-authored-by: Hsiao-nan Cheung <[email protected]> * Update libexec/scoop-search.ps1 Co-authored-by: Hsiao-nan Cheung <[email protected]> * Update libexec/scoop-search.ps1 Co-authored-by: Hsiao-nan Cheung <[email protected]> * Added [JsonDocument]::Parse for testing * Fix array length check * Used wrong function * Add fallback function for PowerShell 5 * Check for System.Text.Json in Assemblies instead * Show help output * Revert "Show help output" This reverts commit d3d6b01. * Update CHANGELOG.md --------- Co-authored-by: Hsiao-nan Cheung <[email protected]> Co-authored-by: Rashil Gandhi <[email protected]>
|
With this now merged, is there an ETA when this will arrive in main? I notice that there hasn't been an update for nearly a year. |
|
You can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is another attempt to improve the local search performance.
manifest()function$apps$listdirectly[System.IO.File]::ReadAllText()instead ofGet-ContentMotivation and Context
Closes #4239
Relates to #4818
How Has This Been Tested?
Checklist:
developbranch.