Skip to content

Added Sega Genesis support by fixing LibretroWraper.cs switch case XR… #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cph5236
Copy link

@cph5236 cph5236 commented Dec 27, 2019

…GB8888 it now uses RGB8888 jobs in unities jobs system, fixed RetroAudioSample function.

…GB8888 it now uses RGB8888 jobs in unities jobs system, fixed RetroAudioSample function.
@cph5236
Copy link
Author

cph5236 commented Aug 4, 2020

Hey Scorr are you going to approve this request?

@supneo
Copy link

supneo commented Aug 29, 2020

Hello, interesting, thanks for the contribution.

@Hokage3211
Copy link

Hey there! Trying to replicate these changes, it didn't work on the plusGX core (getting editor-level crashes), but it does seem to make the blastem core work, however there is large audio crackling as well as the main problem which is the screen being shifted like wrapped a million times the wrong way, in stripes. Did I miss a change or something? I'm mostly hand-reading each line to pull changes, since I already made conflicting changes so I can't just pull merge.

@cph5236
Copy link
Author

cph5236 commented Sep 6, 2020 via email

@Hokage3211
Copy link

Hokage3211 commented Sep 6, 2020

Perhaps there is a missing change in code not commited on your end? I was testing with a sonic the hedgehog 2, what did you use to test? Or if it helps, do you remember what lines of code fixed the warping, and I can see if I have them correct?

@cph5236
Copy link
Author

cph5236 commented Sep 6, 2020 via email

@Scorr
Copy link
Owner

Scorr commented Sep 9, 2020

Hey sorry for the late reply, haven't looked at this repo in a while. I've been wanting to rework it but haven't had time.

Just tested your PR, screen is also warped with stripes for me using blastem. Is there a configuration with which this works that I could test (Game + libretro core)?
The audio crackle is not a problem since that was already an issue before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants