fix(rustchain+beacon): dead /balance endpoint + remove nonexistent gas tools#244
Merged
Merged
Conversation
…tent gas tools Completing the flagship endpoint audit (after the BoTTube fix in #243): RustChain — /balance was 404: GET /balance?miner_id={id} -> GET /balance/{id} (path param; live-verified 200) fixed all 3 call sites (wallet_balance, rustchain_balance, evangelist lookup) Beacon — beacon_gas_balance / beacon_gas_deposit targeted /relay/gas/* which returns 404: the relay (beacon_chat.py) has NO gas routes at all (verified against its route table). Gas was never deployed there, so these two tools could only ever 404. Removed them (+ doc/README references) rather than ship tools that cannot work. The other 8 Beacon tools are live-verified working. Adds path-lock tests for /balance and asserts the gas tools are gone. 145 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
RTC RewardThis merged PR earned 5 RTC — sent to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the flagship endpoint audit started in #243 (BoTTube).
RustChain —
/balancewas 404GET /balance?miner_id={id}→ 404; the live node servesGET /balance/{id}(path param) → 200{amount_i64, balance_rtc, miner_pk}. Fixed all 3 call sites (wallet_balance,rustchain_balance, evangelist balance lookup).Beacon — 2 tools targeted a nonexistent feature
beacon_gas_balance/beacon_gas_depositcall/relay/gas/*, which returns 404. The relay (beacon_chat.py) has no gas routes at all (verified against its full route table) — gas was never deployed there. Removed both tools (and their doc/README references) rather than ship tools that can only 404. The other 8 Beacon tools are live-verified working (/api/agents,/api/chat,/api/contracts,/relay/register|heartbeat|message|status|stats).Verification
/balance/{id}→ 200 live; gas routes confirmed absent in the relay source/balance; test asserts the gas tools are gone🤖 Generated with Claude Code