Skip to content

Conversation

VinciGit00
Copy link
Collaborator

No description provided.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 25, 2025
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Feb 25, 2025
## [1.40.0-beta.1](v1.39.0...v1.40.0-beta.1) (2025-02-25)

### Features

* add refactoring of merge and parse ([2c0b459](2c0b459))
* update parse node ([8cf9685](8cf9685))

### CI

* **release:** 1.39.0-beta.2 [skip ci] ([ac2fcd6](ac2fcd6))
Copy link

🎉 This PR is included in version 1.40.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

codebeaver-ai bot commented Feb 25, 2025

I opened a Pull Request with the following:

🔄 1 test file added.
🐛 Found 1 bug
🛠️ 1/3 tests passed

🔄 Test Updates

I've added 1 tests. They all pass ☑️
New Tests:

  • tests/test_generate_answer_node.py

No existing tests required updates.

🐛 Bug Detection

Potential issues found in the following files:

  • scrapegraphai/nodes/parse_node.py

    The test is written to patch the url_pattern so that it correctly recognizes an absolute URL such as "https://external.com/page". However, when the test is run, the code’s URL extraction logic wrongly concatenates or “loses” the protocol and domain information. Specifically, the patched regex returns only the captured part (e.g. “/page”) instead of the full URL. Later, when all URLs are processed using urljoin with the provided source ("https://mysite.com"), the absolute URL becomes "https://mysite.com/page" rather than "https://external.com/page". This discrepancy between the expected and the actual link in the node’s output indicates a bug in the extraction logic of the code being tested rather than an issue with the test design or the test configuration.
    Thus, the error is caused by a bug in the code.

/bug

🛠️ Test Results

1/3 tests passed ⚠️

tests/graphs/scrape_graph_test.py

View error
ImportError while importing test module '/app/temp_workspace/tests/graphs/scrape_graph_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/graphs/scrape_graph_test.py:10: in <module>
    from scrapegraphai.graphs import ScrapeGraph
E   ImportError: cannot import name 'ScrapeGraph' from 'scrapegraphai.graphs' (/app/temp_workspace/scrapegraphai/graphs/__init__.py)

tests/graphs/scrape_graph_test.py

tests/graphs/xml_scraper_openai_test.py

View error
ImportError while importing test module '/app/temp_workspace/tests/graphs/xml_scraper_openai_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/graphs/xml_scraper_openai_test.py:11: in <module>
    from scrapegraphai.utils import convert_to_csv, convert_to_json, prettify_exec_info
E   ImportError: cannot import name 'convert_to_csv' from 'scrapegraphai.utils' (/app/temp_workspace/scrapegraphai/utils/__init__.py)

tests/graphs/xml_scraper_openai_test.py

☂️ Coverage Improvements

Coverage improvements by file:

  • tests/test_generate_answer_node.py

    New coverage: 76.98%
    Improvement: +76.98%

🎨 Final Touches

  • I ran the hooks included in the pre-commit config.

Settings | Logs | CodeBeaver

@codebeaver-ai codebeaver-ai bot mentioned this pull request Feb 25, 2025
@VinciGit00 VinciGit00 merged commit a3bf169 into main Feb 25, 2025
5 checks passed
Copy link

🎉 This PR is included in version 1.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released on @dev released on @stable size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants