Repository navigation
test(index): await the serving seat without a publication gate - #4731
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
The ignored-dependency fixture checked a complete seat and then subscribed to an earlier publication broadcast. A publication between those operations left three admission tests waiting five seconds for an event already sent. Remove the redundant wait: latest() already requires complete, fresh serving state, so the existing admission regressions now await the actual authority.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ScriptedAlchemy
added a commit
that referenced
this pull request
Nov 3, 2026
Apply the already-reviewed fixture repair from fbca068 (#4731) to this branch after its private Linux run failed at the redundant generation-publication wait. The original fixture blob matches exactly. Keep the stronger fresh serving-seat wait and all admission assertions. No deadline increases, production changes, or validation skips. The shared repair passed native Linux on #4731; this branch's new integration still requires its own hosted Bazel validation. No local Rust execution is claimed.
ScriptedAlchemy
added a commit
that referenced
this pull request
Nov 3, 2026
Apply the reviewed fixture repair from fbca068 (#4731) after this branch's private Linux run failed three admission tests at the redundant generation-publication wait. The original fixture blob matches exactly. Retain the stronger fresh serving-seat wait and every admission assertion. No timeout increases, production changes, or validation skips. The independent cold-daemon Git topology failure is not addressed by this repair. The shared repair passed native Linux on #4731; the updated Grafeo branch still needs its own full hosted Bazel validation. No local Rust execution is claimed.
This was referenced Nov 3, 2026
ScriptedAlchemy
added a commit
that referenced
this pull request
Nov 3, 2026
Use the validated shared fixture repair from #4731 after this branch's native Linux tests failed in the ignored-dependency publication race. The fixture now relies only on its canonical fresh serving-generation wait instead of missing a completed publication broadcast. Keep the stronger readiness assertion, its deadline and every admission regression. The matching source change passed native Linux in #4731; this branch's separate search quality regressions and full CI remain unresolved.
This was referenced Nov 3, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
ignored_dependency_admission_tests::Fixture::mountchecked the latest seated generation, then subscribed to the earlier generation-publication broadcast. If the broadcast arrived between those operations, the fixture waited five seconds for an event already delivered and three otherwise unrelated admission tests failed under CI load. The same failure mechanism was previously repaired in the sibling scope fixture by #3487.Change
Remove that redundant publication wait and its unused identity import. The existing
latest()readiness helper already waits for a complete, fresh serving generation and refuses to return on publication alone. No timeout, assertion, ownership boundary or product code changes. Existing read-only, stale-pin and foreign-scope tests still exercise the full mounted fixture and are the behavioral regressions.Evidence and validation
The same three tests failed at
ignored_dependency_admission_tests.rs:260in unrelated current-head Linux CI for #4721 and #4716. Reviewed the existing fixture, scheduler readiness helper and prior merged #3487 race reproduction. Verified the exact source patch against currentmasterand the published Git blob; no checkout or Bazel toolchain is available here, so Rust tests and full CI have not run on this commit. Hosted Bazel must validate//crates/tracedecay-code-index-runtime:unit_testand the complete applicable matrix before merge.This PR is independent of #4721's Grafeo dependency change and #4716's sealed generation retirement. It does not assert those PRs are otherwise fully passing.