Publish schedule data as JSON #468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested this with and without the scheduling YAML data removed in commit 670dffd.
There was a problem hiding this comment.
We’re plucking out schedule.streams but still calling that “schedule”. I think for consistency it should either be named “streams” or include the whole schedule.
| See https://github.com/SeaGL/birdhouse | ||
| {% endcomment %} | ||
|
|
||
| {% if site.data.schedule.streams %} |
There was a problem hiding this comment.
Is there really no way to use default here? Liquid perpetually baffles me.
Comment on lines
+5
to
+6
| This data gets removed in the off-season, so in this case we simply render | ||
| empty array (for no streams). |
There was a problem hiding this comment.
Instead of serving empty data year round can Birdhouse just handle the case of missing data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this with and without the scheduling YAML data removed in commit 670dffd.