Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheets viewer final #2282

Open
wants to merge 374 commits into
base: modularization-main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
374 commits
Select commit Hold shift + click to select a range
0b7e06c
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Sep 22, 2024
f1455b6
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Sep 22, 2024
33968cc
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Sep 22, 2024
79bd496
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Sep 22, 2024
9a6bb05
chore: fix imports
stevekaplan123 Sep 23, 2024
85263f5
Merge branch 'feature/sc-27313/remove-resources-panel' into feature/s…
stevekaplan123 Sep 23, 2024
2907f1b
Merge branch 'feature/sc-27320/remove-reader-header-bar' into feature…
stevekaplan123 Sep 23, 2024
ab9c9fa
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Sep 23, 2024
a012676
chore: fix imports
stevekaplan123 Sep 23, 2024
b1d85ee
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Sep 23, 2024
63b4d8f
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Sep 23, 2024
f3f0508
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Sep 23, 2024
6c7537b
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Sep 23, 2024
3cc04d1
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Sep 23, 2024
a5fa6e8
chore: center add to sheet button
stevekaplan123 Sep 23, 2024
6edaf6f
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Sep 23, 2024
d4adc08
chore: remove css counter
stevekaplan123 Sep 23, 2024
21c658e
chore: add to sheet position for multiple types of sheet segments
stevekaplan123 Sep 23, 2024
d79c897
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Sep 23, 2024
db07560
chore: center plus sign in add to sheet button
stevekaplan123 Sep 23, 2024
300a499
chore: remove letter spacing in dropdown in sheet content
stevekaplan123 Sep 24, 2024
6f46167
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Sep 24, 2024
f01d99c
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Sep 24, 2024
c1d2dcf
chore: sheet modal css
stevekaplan123 Sep 24, 2024
4e02a39
chore: modal useeffect
stevekaplan123 Sep 25, 2024
f40e07c
chore: modal almost works for all cases by changing showModal to show
stevekaplan123 Sep 25, 2024
2ca531f
chore: use ProfileSummary in SheetSIdebar
stevekaplan123 Sep 30, 2024
737feef
chore: start refactoring ProfileSummary
stevekaplan123 Sep 30, 2024
adc796d
chore: refactor UserProfile to use new component ProfileBio
stevekaplan123 Oct 1, 2024
b259928
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 1, 2024
e98968c
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 1, 2024
48e5776
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 1, 2024
d24fed3
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 1, 2024
b7a24e2
chore: rename SheetSidebar to SheetContentSidebar
stevekaplan123 Oct 1, 2024
f103934
chore: finish renaming SheetSidebar to SheetContentSidebar
stevekaplan123 Oct 1, 2024
d161631
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 1, 2024
c5d4efd
chore: refactor CopyModal to show without dropdown menu showing
stevekaplan123 Oct 1, 2024
330a592
chore: changed component name but forgot to change its usage
stevekaplan123 Oct 1, 2024
b4c505c
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 1, 2024
404a21f
chore: stop propagation at modal-content not dialog
stevekaplan123 Oct 1, 2024
edd35cc
chore: use loaded variable so as not to call multiple times
stevekaplan123 Oct 1, 2024
b7ffcf2
chore: start building modals for each sheet option
stevekaplan123 Oct 8, 2024
6c5df97
chore: start implementing SaveButtonWithText
stevekaplan123 Oct 8, 2024
303ad91
chore: create SaveButtonWithText
stevekaplan123 Oct 9, 2024
a19ad8d
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 9, 2024
7cedb4b
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 9, 2024
a34f6a6
chore: start implementing GoogleDocExportModal
stevekaplan123 Oct 9, 2024
901fb58
Merge branch 'modularization-main' into feature/sc-27826/styling
stevekaplan123 Oct 9, 2024
0feb16d
Merge branch 'modularization-main' into feature/sc-27313/remove-resou…
stevekaplan123 Oct 9, 2024
c640aad
Merge branch 'feature/sc-27313/remove-resources-panel' into feature/s…
stevekaplan123 Oct 9, 2024
8ccc9f2
Merge branch 'feature/sc-27320/remove-reader-header-bar' into feature…
stevekaplan123 Oct 9, 2024
1d01a61
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Oct 9, 2024
2789417
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 9, 2024
b81d8ff
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 9, 2024
7e41c42
chore: fix merge conflict
stevekaplan123 Oct 9, 2024
25cbe8c
chore: fix broken save buttonwithtext
stevekaplan123 Oct 9, 2024
b0fe208
chore: only save Sheet 3 not Sheet 3:4
stevekaplan123 Oct 9, 2024
adefdd3
chore: GenericSheetModal
stevekaplan123 Oct 9, 2024
14bb5e5
chore: fix GenericSheetModal
stevekaplan123 Oct 9, 2024
330bcfa
chore: implement GoogleDocExportModal
stevekaplan123 Oct 10, 2024
307db39
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 10, 2024
a1f06cd
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 10, 2024
aebe5fc
chore: remove 0 from ProfileBio
stevekaplan123 Oct 10, 2024
9d975d9
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 10, 2024
f63dcd1
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 10, 2024
0fb30da
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 10, 2024
4521481
chore: align user name + pic to right in hebrew
stevekaplan123 Oct 10, 2024
dec02da
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Oct 10, 2024
7d8029b
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 10, 2024
f6e3ff8
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 10, 2024
b9a3fb5
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 10, 2024
6b2c568
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 10, 2024
aaac7c4
chore: make buttons green in sheets
stevekaplan123 Oct 10, 2024
377a82d
chore: dont keep calling /api/sheets
stevekaplan123 Oct 10, 2024
882299a
chore: sheets API still getting triggered multiple times, so change w…
stevekaplan123 Oct 13, 2024
70cdcfa
chore: get toggleSignUpModal to work in sheet options
stevekaplan123 Oct 13, 2024
ea643b4
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 13, 2024
c747d0e
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 13, 2024
11c1c10
chore: export should togglesignupmodal
stevekaplan123 Oct 13, 2024
8a29e95
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 13, 2024
9c94edc
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 13, 2024
dece1a7
chore: fix styling of sheet options menu
stevekaplan123 Oct 14, 2024
f96e199
chore: different types of toggles for sheet options
stevekaplan123 Oct 14, 2024
6f4f9ad
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 14, 2024
2156d5f
chore: add to sheet button when logged out should trigger sign up modal
stevekaplan123 Oct 14, 2024
b82fa58
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 14, 2024
9a089d0
chore: can add images to sheets
stevekaplan123 Oct 14, 2024
8e1cde9
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 14, 2024
3b488f0
chore: syntax fix
stevekaplan123 Oct 14, 2024
68aa951
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 14, 2024
02d95fd
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 14, 2024
d84f8fb
chore: dont justify titles
stevekaplan123 Oct 14, 2024
eda6385
chore: fix buttons in sheet content
stevekaplan123 Oct 14, 2024
a91b1ff
chore: fix styling of addtosheetbutton thats part of an image
stevekaplan123 Oct 14, 2024
d1808a8
chore: use css variable
stevekaplan123 Oct 15, 2024
d3b587e
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Oct 15, 2024
e368269
chore: use var for css color
stevekaplan123 Oct 15, 2024
e4329bc
chore: break down ProfileSummary into logical components, including n…
stevekaplan123 Oct 15, 2024
ed1fc2a
Merge branch 'feature/sc-29713/create-profilebio-component-for-sideba…
stevekaplan123 Oct 15, 2024
fd8b874
chore: use better css names for PartOfCollections component
stevekaplan123 Oct 15, 2024
a83b0fd
chore: undo changes to SheetAuthorStatement which is unused by Sheets…
stevekaplan123 Oct 15, 2024
c1221a0
chore: remove unnecessary import
stevekaplan123 Oct 15, 2024
b748954
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 15, 2024
140c01c
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 15, 2024
4faae69
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 15, 2024
26c974a
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 15, 2024
856ea75
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Oct 15, 2024
e91b39e
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Oct 15, 2024
f1b52d8
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Oct 15, 2024
f1124b7
chore: undo unnecessary changes to ModuleSwitcher
stevekaplan123 Oct 15, 2024
3fe931e
chore: use DropdownMenuItemWithIcon instead of ToolsButton
stevekaplan123 Oct 15, 2024
444f963
chore: unnecessary comma
stevekaplan123 Oct 15, 2024
846c176
chore: dont need masterPanelSheetId
stevekaplan123 Oct 15, 2024
ef2f8a4
Merge branch 'feature/sc-27313/remove-resources-panel' into feature/s…
stevekaplan123 Oct 15, 2024
6f39609
Merge branch 'feature/sc-27320/remove-reader-header-bar' into feature…
stevekaplan123 Oct 15, 2024
e2193cc
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-29713/cr…
stevekaplan123 Oct 15, 2024
57d458b
Merge branch 'feature/sc-29713/create-profilebio-component-for-sideba…
stevekaplan123 Oct 15, 2024
e20f0c3
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Oct 15, 2024
382ec0a
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Oct 15, 2024
4325779
chore: make font weights 400
stevekaplan123 Oct 28, 2024
f04d62d
chore: add 500 & 600 as font weight options for roboto
stevekaplan123 Nov 7, 2024
15ed7fc
chore: use new font weight options
stevekaplan123 Nov 7, 2024
6d1a223
chore: modify SheetMetaDataBox
stevekaplan123 Nov 10, 2024
aa9c709
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-29713/cr…
stevekaplan123 Nov 10, 2024
86f7dce
Merge branch 'feature/sc-29713/create-profilebio-component-for-sideba…
stevekaplan123 Nov 10, 2024
9070891
Merge branch 'feature/sc-29713/create-profilebio-component-for-sideba…
stevekaplan123 Nov 10, 2024
d6c4452
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Nov 10, 2024
37d0c6f
chore: modify sheetmetadatabox based on merge
stevekaplan123 Nov 10, 2024
af62b67
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Nov 10, 2024
8b74a02
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Nov 10, 2024
1ebf583
chore: better variable names
stevekaplan123 Nov 12, 2024
ea901a8
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Nov 12, 2024
d98244c
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Nov 12, 2024
455c77c
Merge branch 'feature/sc-27826/styling' into feature/sc-30600/impleme…
stevekaplan123 Nov 26, 2024
7fac1a6
fix(Sheets): dont need to call related API anymore
stevekaplan123 Nov 26, 2024
f92ee59
chore: minor syntax change
stevekaplan123 Nov 26, 2024
f7f300a
Merge branch 'modularization-main' into feature/sc-27313/remove-resou…
stevekaplan123 Nov 28, 2024
2c86216
Merge branch 'modularization-main' into feature/sc-27320/remove-reade…
stevekaplan123 Nov 28, 2024
9a17c0e
Merge branch 'feature/sc-27320/remove-reader-header-bar' into feature…
stevekaplan123 Nov 28, 2024
4553f07
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Nov 28, 2024
11a0cf6
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Nov 28, 2024
b8a9dda
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Nov 28, 2024
54b09c9
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Nov 28, 2024
112c5f8
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Nov 28, 2024
fa7fe65
Merge branch 'feature/sc-27826/styling' into feature/sc-30600/impleme…
stevekaplan123 Nov 28, 2024
b296a48
chore: rename shared to common
stevekaplan123 Nov 28, 2024
96e0c8f
chore: dropdown menu_icon to menuIconComponent
stevekaplan123 Nov 28, 2024
b43a86b
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Nov 28, 2024
ef03a7c
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Nov 28, 2024
f44a560
Merge branch 'feature/sc-27826/styling' into feature/sc-30600/impleme…
stevekaplan123 Nov 28, 2024
31e0989
Merge branch 'feature/sc-27313/remove-resources-panel' into feature/s…
stevekaplan123 Nov 28, 2024
3b848aa
Merge branch 'feature/sc-27320/remove-reader-header-bar' into feature…
stevekaplan123 Nov 28, 2024
c3fb6ea
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Nov 28, 2024
f091da9
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Nov 28, 2024
00cbf66
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Nov 28, 2024
22242b1
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Nov 28, 2024
a21c7a9
Merge branch 'feature/sc-27825/add-to-sheet' into feature/sc-27826/st…
stevekaplan123 Nov 28, 2024
d03da25
chore: URL 1.2 loads to 2nd segment
stevekaplan123 Nov 28, 2024
dab6fa7
chore: Sheet should appear as menu instead of items
stevekaplan123 Nov 28, 2024
970ea8f
Merge pull request #2067 from Sefaria/feature/sc-27320/remove-reader-…
yitzhakc Nov 28, 2024
2432de3
chore: revert sheetcontent commit
stevekaplan123 Dec 3, 2024
2cdfc58
Merge pull request #2068 from Sefaria/feature/sc-29344/sheet-header
yitzhakc Dec 4, 2024
55795da
chore: rename to SheetContent
stevekaplan123 Dec 4, 2024
070c47e
chore: Sheet to SheetCopy
stevekaplan123 Dec 4, 2024
3fcb11c
Merge commit '55795da993138c0af0590d36b877ef512f4f1ff2' into feature/…
stevekaplan123 Dec 4, 2024
32b55a6
chore: rename SheetCopy to Sheet
stevekaplan123 Dec 4, 2024
432112a
chore: change some import statements for sheetcontent
stevekaplan123 Dec 4, 2024
3ded56f
Merge branch 'feature/sc-27313/remove-resources-panel' into feature/s…
stevekaplan123 Dec 4, 2024
f281d2e
Merge branch 'feature/sc-29344/sheet-header' into feature/sc-27331/ne…
stevekaplan123 Dec 4, 2024
42cc83e
Merge branch 'feature/sc-27331/new-sidebar-component' into feature/sc…
stevekaplan123 Dec 4, 2024
ed33a24
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab' i…
stevekaplan123 Dec 4, 2024
3cb406e
Merge branch 'feature/sc-27328/options-popover-component' into featur…
stevekaplan123 Dec 4, 2024
330dd3f
Merge branch 'feature/sc-27320/remove-reader-header-bar' into feature…
stevekaplan123 Dec 5, 2024
c02461a
Merge pull request #2064 from Sefaria/feature/sc-27313/remove-resourc…
yitzhakc Dec 10, 2024
13a173f
Merge branch 'sheets-viewer-final' into feature/sc-27331/new-sidebar-…
stevekaplan123 Dec 10, 2024
573a787
chore: fix import
stevekaplan123 Dec 10, 2024
9de360f
Merge branch 'feature/sc-27331/new-sidebar-component2' into feature/s…
stevekaplan123 Dec 10, 2024
bea5b97
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Dec 10, 2024
4aa8b8c
Merge branch 'feature/sc-27328/options-popover-component2' into featu…
stevekaplan123 Dec 10, 2024
c4d2052
Merge branch 'feature/sc-27825/add-to-sheet2' into feature/sc-27826/s…
stevekaplan123 Dec 10, 2024
ed30863
chore: ajax to fetch
stevekaplan123 Dec 11, 2024
686dd52
chore: export fails to return webViewLink
stevekaplan123 Dec 11, 2024
10032f0
chore: need to convert response to json in google export
stevekaplan123 Dec 11, 2024
5807252
chore: add comment
stevekaplan123 Dec 11, 2024
3605398
Merge branch 'modularization-main2' into sheets-viewer-final
stevekaplan123 Dec 11, 2024
415106e
Merge branch 'modularization-main2' into feature/sc-27327/source-clic…
stevekaplan123 Dec 11, 2024
a1f0e4d
chore: fix imports
stevekaplan123 Dec 11, 2024
8956559
Merge branch 'feature/sc-27328/options-popover-component2' into featu…
stevekaplan123 Dec 11, 2024
3c32ee3
Merge branch 'feature/sc-27825/add-to-sheet2' into feature/sc-27826/s…
stevekaplan123 Dec 11, 2024
eaa3fb8
Merge branch 'modularization-main' into sheets-viewer-final
stevekaplan123 Dec 12, 2024
f7ff974
Merge branch 'sheets-viewer-final' into feature/sc-27331/new-sidebar-…
stevekaplan123 Dec 12, 2024
d05d8d6
Merge branch 'feature/sc-27331/new-sidebar-component2' into feature/s…
stevekaplan123 Dec 12, 2024
05bf255
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Dec 12, 2024
09f647e
Merge branch 'feature/sc-27328/options-popover-component2' into featu…
stevekaplan123 Dec 12, 2024
62350fd
Merge branch 'feature/sc-27825/add-to-sheet2' into feature/sc-27826/s…
stevekaplan123 Dec 12, 2024
07bc2b9
chore: followbutton should trigger togglesignupmodal
stevekaplan123 Dec 12, 2024
7259503
Merge branch 'feature/sc-27331/new-sidebar-component2' into feature/s…
stevekaplan123 Dec 12, 2024
949ded2
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Dec 12, 2024
6b8cb16
chore: remove unnecessary console log
stevekaplan123 Dec 12, 2024
689bd2a
chore: fix imports
stevekaplan123 Dec 12, 2024
6498cff
Merge branch 'feature/sc-27331/new-sidebar-component2' into feature/s…
stevekaplan123 Dec 12, 2024
9310109
chore: use utility function
stevekaplan123 Dec 15, 2024
006ea3d
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Dec 15, 2024
7466742
Merge branch 'feature/sc-27328/options-popover-component2' into featu…
stevekaplan123 Dec 15, 2024
c802b75
Merge branch 'feature/sc-27825/add-to-sheet2' into feature/sc-27826/s…
stevekaplan123 Dec 15, 2024
e8bdade
chore: remove profile pic from sheetmetadatabox
stevekaplan123 Dec 15, 2024
3120e70
chore: style changes
stevekaplan123 Dec 15, 2024
d8700a7
chore: remove console log
stevekaplan123 Dec 15, 2024
8b81cbc
chore: sheet notice not used
stevekaplan123 Dec 15, 2024
9fd1a76
chore: remove console log
stevekaplan123 Dec 15, 2024
faf1de5
chore: rename PartOfCollections to SheetCollectionsList
stevekaplan123 Dec 16, 2024
e622546
Merge branch 'modularization-main' into feature/sc-27331/new-sidebar-…
stevekaplan123 Dec 16, 2024
d8deb68
chore: rename profilebio to userbackground
stevekaplan123 Dec 17, 2024
da1ef38
chore: render HTML for profile bio
stevekaplan123 Dec 17, 2024
a2f4e6d
Merge branch 'feature/sc-27331/new-sidebar-component2' into feature/s…
stevekaplan123 Dec 17, 2024
e7b0cf6
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Dec 17, 2024
4a1ecf5
Merge branch 'feature/sc-27328/options-popover-component2' into featu…
stevekaplan123 Dec 17, 2024
054d1a2
Merge branch 'feature/sc-27825/add-to-sheet2' into feature/sc-27826/s…
stevekaplan123 Dec 17, 2024
6d4b655
Merge pull request #2173 from Sefaria/feature/sc-27826/styling
yitzhakc Jan 7, 2025
eb1abb7
chore: refactor getSources in SheetContent
stevekaplan123 Jan 8, 2025
030fa8b
chore: remove white spaces
stevekaplan123 Jan 8, 2025
34400cc
chore: handleKeyPress as a prop to SheetContentSegments
stevekaplan123 Jan 8, 2025
827e6f4
chore: fix spacing in code
stevekaplan123 Jan 12, 2025
7037c4f
chore: spacing in code
stevekaplan123 Jan 12, 2025
cce81ce
chore: clarify code in getSources
stevekaplan123 Jan 12, 2025
13625a8
Merge branch 'modularization-main' into sheets-viewer-final
stevekaplan123 Jan 12, 2025
89da2f0
Merge branch 'sheets-viewer-final' into feature/sc-27331/new-sidebar-…
stevekaplan123 Jan 12, 2025
8219df4
Merge branch 'feature/sc-27331/new-sidebar-component2' into feature/s…
stevekaplan123 Jan 12, 2025
9f8643f
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Jan 12, 2025
619cfad
chore: fix syntax
stevekaplan123 Jan 12, 2025
e605ab4
Merge branch 'feature/sc-27328/options-popover-component2' into featu…
stevekaplan123 Jan 12, 2025
3ecaca0
Merge pull request #2172 from Sefaria/feature/sc-27328/options-popove…
stevekaplan123 Jan 13, 2025
2c64733
Merge pull request #2163 from Sefaria/feature/sc-27331/new-sidebar-co…
yitzhakc Jan 13, 2025
f4ee9f7
Merge branch 'modularization-main-merge-master' into sheets-viewer-final
stevekaplan123 Jan 16, 2025
fe524ca
Merge branch 'sheets-viewer-final' into feature/sc-27327/source-click…
stevekaplan123 Jan 16, 2025
614b8b2
Merge branch 'feature/sc-27327/source-click-should-open-in-new-tab2' …
stevekaplan123 Jan 16, 2025
0ae70b6
chore: handle bad data
stevekaplan123 Jan 16, 2025
15b021c
chore: create SheetModals.jsx
stevekaplan123 Jan 20, 2025
342121f
chore: change import
stevekaplan123 Jan 20, 2025
fac73db
Merge pull request #2179 from Sefaria/feature/sc-27825/add-to-sheet2
stevekaplan123 Jan 21, 2025
1a3b785
chore: use DropdownMenuItemWithCallback
stevekaplan123 Jan 21, 2025
94327de
chore: started refactoring Modal
stevekaplan123 Jan 21, 2025
d6abcac
chore: click outside closes modal
stevekaplan123 Jan 21, 2025
4f456d0
chore: make div button
stevekaplan123 Jan 22, 2025
c021105
chore: adjust dialog
stevekaplan123 Jan 22, 2025
47119cd
chore: dont let user close copy modal while copying
stevekaplan123 Jan 22, 2025
aa6b03e
Merge pull request #2164 from Sefaria/feature/sc-27327/source-click-s…
yitzhakc Jan 26, 2025
8e619c0
Merge branch 'modularization-main' into sheets-viewer-final
stevekaplan123 Jan 28, 2025
7ab1b1e
Merge branch 'modularization-main' into sheets-viewer-final
stevekaplan123 Feb 6, 2025
0cb4b2a
Merge branch 'modularization-main' into sheets-viewer-final
stevekaplan123 Feb 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions sefaria/sheets.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def get_sheet_for_panel(id=None):
sheet["ownerImageUrl"] = public_user_data(sheet["owner"])["imageUrl"]
sheet["sources"] = annotate_user_links(sheet["sources"])
sheet["topics"] = add_langs_to_topics(sheet.get("topics", []))
sheet["sheetNotice"] = present_sheet_notice(sheet.get("is_moderated", None))
if "displayedCollection" in sheet:
collection = Collection().load({"slug": sheet["displayedCollection"]})
if collection:
Expand Down Expand Up @@ -1287,8 +1286,3 @@ def update_sheet_tags_categories(body, uid):
time = datetime.now().isoformat()
noTags = time if body.get("noTags", False) else False
db.sheets.update_one({"id": body['sheetId']}, {"$set": {"categories": body['categories'], "noTags": noTags}, "$push": {"moderators": {"uid": uid, "time": time}}})


def present_sheet_notice(is_moderated):
"""This method is here in case one day we will want to differentiate based on other logic on moderation"""
return is_moderated
2 changes: 1 addition & 1 deletion sourcesheets/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ def save_sheet_api(request):
else:
apikey = None

j = request.POST.get("json")
j = request.POST.get("json") or request.body
if not j:
return jsonResponse({"error": "No JSON given in post data."})
sheet = json.loads(j)
Expand Down
Loading
Loading