Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new themable button in the sheets homepage #2323

Draft
wants to merge 1 commit into
base: modulrization-themes
Choose a base branch
from
Draft

Use the new themable button in the sheets homepage #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion static/css/s2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1817,9 +1817,12 @@ div.interfaceLinks-row a {
.navSidebar .linkList {
margin-top: 20px;
}
.navSidebarModule .button {
.navSidebarModule .button{
margin: 12px 0 0 0;
}
.navSidebarModule .sidebarModuleText{
margin-bottom: 12px;
}
.navSidebarModule .button img {
filter: invert(1);
height: 18px;
Expand Down
12 changes: 9 additions & 3 deletions static/js/NavSidebar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ const SidebarModuleTitle = ({children, en, he}) => {
const TitledText = ({children, title, text}) => {
return <SidebarModule>
<SidebarModuleTitle en={title.en} he={title.he}/>
<InterfaceText markdown={{en: text.en, he: text.he}} />
<p class="sidebarModuleText">
<InterfaceText markdown={{en: text.en, he: text.he}} />
</p>
{children}
</SidebarModule>
};
Expand Down Expand Up @@ -727,11 +729,15 @@ const StayConnected = () => { // TODO: remove? looks like we are not using this

const GetStartedButton = () => {
const href = Sefaria._v({"en": "/sheets/393695", "he": "/sheets/399333"})
return <Button className="getStartedSheets" onClick={() => window.location.href=href}>Get Started</Button>;
return <Button variant="secondary" className="getStartedSheets" onClick={() => window.location.href=href}>Get Started</Button>;
}
const CreateSheetsButton = () => {
// #sheetsButton
return <Button icon={"/static/icons/new-sheet-black.svg"} className="small" onClick={() => window.location.href="/sheets/new"}>Create</Button>
return (
<Button icon={"new-sheet-black"} onClick={() => window.location.href="/sheets/new"}>
<InterfaceText text={{'en': 'Create', 'he': 'דף חדש'}} />
</Button>
) // hebrew is placeholder
}
const CreateASheet = () => (
<TitledText title={{'en': 'Create A Sheet', 'he': ''}}
Expand Down
Loading