Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new property Description from Description2 #205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bertrandgorge
Copy link

Hello,

This is a little attempt at adding a new extra property for the description of the page, as computed by the extension Description2.

I was not sure about the unit test so there's some work on that remaining. Appart from that it seems to work as intended.

I let you decide if you think it is worthy adding !

@krabina
Copy link
Contributor

krabina commented Dec 12, 2022

Did you also test what happens if the Description2 extension is not installed?

@bertrandgorge
Copy link
Author

bertrandgorge commented Dec 12, 2022

Hello @krabina yes there's no hard dependency on the Description2 extension as it only looks for the presence of the Parser property "description" (see

if ( $description !== false ) { // set by Description2 extension, install it if you want proper og:description support
)

NB : for the moment I won't personaly be using this code, so there's no pressing at merging anything. It's just there if someone finds it useful enough ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants