Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LinksTo Property #216

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

octfx
Copy link
Contributor

@octfx octfx commented Jun 24, 2023

This PR adds a new Links to property that records pages to which a page links.

The namespaces where this property is allowed to be active can be configured using $sespgLinksToEnabledNamespaces.

Example:
$sespgLinksToEnabledNamespaces = [ 10, 838 ]; would activate the Links to property only on Template and Module namespaces.

This PR includes:

  • Tests (unit)
  • CI build passed

image

data/definitions.json Outdated Show resolved Hide resolved
@octfx octfx force-pushed the master branch 2 times, most recently from 939e19e to 54b768f Compare June 25, 2023 08:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Attention: Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (b5af401) to head (3fc38c6).
Report is 101 commits behind head on master.

Files with missing lines Patch % Lines
...rc/PropertyAnnotators/LinksToPropertyAnnotator.php 54.28% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #216      +/-   ##
============================================
- Coverage     91.42%   90.19%   -1.24%     
- Complexity      357      368      +11     
============================================
  Files            35       36       +1     
  Lines          1015     1050      +35     
============================================
+ Hits            928      947      +19     
- Misses           87      103      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alistair3149
Copy link
Contributor

@JeroenDeDauw Hi there! It has been a while since the CR is addressed and would you be able to take a look at the patch again?

@JeroenDeDauw JeroenDeDauw merged commit 63bf7dd into SemanticMediaWiki:master Oct 25, 2024
@jaideraf
Copy link
Member

@alistair3149 or @octfx please add documentation of the new feature at least here: https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/blob/master/docs/configuration.md

@alistair3149
Copy link
Contributor

PR opened at #245 for documentation

alistair3149 added a commit to alistair3149/SemanticExtraSpecialProperties that referenced this pull request Oct 25, 2024
JeroenDeDauw pushed a commit that referenced this pull request Oct 26, 2024
* docs: add _LINKSTO to configuration

Follow up to #216

* style: fix various issues raised by phpcs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants