Skip to content

fix: recognize GLM-5.2 ingest results #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adibarra merged 1 commit into from
Jul 18, 2026
Merged

fix: recognize GLM-5.2 ingest results #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/app/src/lib/compare-slug.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ describe('compareModelDisplayLabel', () => {
expect(compareModelDisplayLabel(KIMI_K26, 'gb200', 'mi355x')).toBe(
'Kimi K2.5/K2.6/K2.7-Code 1T — GB200 NVL72 vs MI355X',
);
expect(compareModelDisplayLabel(GLM_51, 'h100', 'h200')).toBe('GLM 5/5.1/5.2 — H100 vs H200');
});
});

Expand Down
8 changes: 4 additions & 4 deletions packages/app/src/lib/compare-slug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ export const COMPARE_MODEL_SLUGS: CompareModelSlug[] = [
{
slug: 'glm-5-1',
displayName: 'GLM-5',
// GLM-5.0 and GLM-5.1 share an architecture per the model card; the slug
// uses the newer version name but the data pull covers both DB buckets.
dbKeys: ['glm5.1', 'glm5'],
label: 'GLM 5/5.1',
// GLM-5 point releases share the same base architecture. Keep the existing
// canonical slug for URL stability while querying every DB bucket.
dbKeys: ['glm5.2', 'glm5.1', 'glm5'],
label: 'GLM 5/5.1/5.2',
},
{
slug: 'minimax-m3',
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/lib/data-mappings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ describe('getModelLabel', () => {
expect(getModelLabel(Model.GptOss)).toBe('gpt-oss 120B');
expect(getModelLabel(Model.Qwen3_5)).toBe('Qwen3.5 397B');
expect(getModelLabel(Model.Kimi_K2_5)).toBe('Kimi K2.5/2.6/2.7-Code 1T');
expect(getModelLabel(Model.GLM_5)).toBe('GLM5/5.1 744B');
expect(getModelLabel(Model.GLM_5)).toBe('GLM5/5.1/5.2 744B');
expect(getModelLabel(Model.MiniMax_M2_5)).toBe('MiniMax M2.5/2.7 230B');
});

Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/lib/data-mappings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const MODEL_CONFIG: Record<Model, ModelConfig> = {
prefix: 'dsr1',
category: 'maintenance',
},
[Model.GLM_5]: { label: 'GLM5/5.1 744B', prefix: 'glm5', category: 'default' },
[Model.GLM_5]: { label: 'GLM5/5.1/5.2 744B', prefix: 'glm5', category: 'default' },
[Model.Qwen3_5]: { label: 'Qwen3.5 397B', prefix: 'qwen3.5', category: 'default' },
[Model.GptOss]: { label: 'gpt-oss 120B', prefix: 'gptoss', category: 'deprecated' },
[Model.MiniMax_M2_5]: {
Expand Down
4 changes: 3 additions & 1 deletion packages/app/src/lib/models-mapping.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ describe('DISPLAY_MODEL_TO_DB', () => {
});

it('groups point-release DB keys under one display', () => {
expect(DISPLAY_MODEL_TO_DB['GLM-5']).toEqual(expect.arrayContaining(['glm5', 'glm5.1']));
expect(DISPLAY_MODEL_TO_DB['GLM-5']).toEqual(
expect.arrayContaining(['glm5', 'glm5.1', 'glm5.2']),
);
});
});

Expand Down
4 changes: 3 additions & 1 deletion packages/constants/src/models.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ describe('DB_MODEL_TO_DISPLAY / DISPLAY_MODEL_TO_DB consistency', () => {
});

it('groups point-release DB keys under the same display name', () => {
expect(DISPLAY_MODEL_TO_DB['GLM-5']).toEqual(expect.arrayContaining(['glm5', 'glm5.1']));
expect(DISPLAY_MODEL_TO_DB['GLM-5']).toEqual(
expect.arrayContaining(['glm5', 'glm5.1', 'glm5.2']),
);
expect(DISPLAY_MODEL_TO_DB['Kimi-K2.5']).toEqual(
expect.arrayContaining(['kimik2.5', 'kimik2.6', 'kimik2.7-code']),
);
Expand Down
1 change: 1 addition & 0 deletions packages/constants/src/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export const DB_MODEL_TO_DISPLAY: Record<string, string> = {
minimaxm3: 'MiniMax-M3',
glm5: 'GLM-5',
'glm5.1': 'GLM-5',
'glm5.2': 'GLM-5',

@cursor cursor Bot Jul 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing FAQ GLM-5.2 override

Low Severity

Adding glm5.2 under the shared GLM-5 display name without a matching about-page override leaves /about listing GLM-5 twice and omitting GLM-5.2. Those FAQ maps intentionally expand point-release DB buckets (glm5.1, kimik2.6, kimik2.7-code, minimaxm2.7), so the new key needs the same treatment in both locale files.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5efdf35. Configure here.

dsv4: 'DeepSeek-V4-Pro',
};

Expand Down
3 changes: 3 additions & 0 deletions packages/db/src/etl/normalizers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,16 @@ describe('resolveModelKey', () => {
expect(resolveModelKey({ model: 'moonshotai/Kimi-K2.5' })).toBe('kimik2.5');
expect(resolveModelKey({ model: 'MiniMaxAI/MiniMax-M2.5' })).toBe('minimaxm2.5');
expect(resolveModelKey({ model: 'zai-org/GLM-5-FP8' })).toBe('glm5');
expect(resolveModelKey({ model: 'zai-org/GLM-5.2-FP8' })).toBe('glm5.2');
});

it('resolves point-release variants to their own DB key (faithful to submitted data)', () => {
expect(resolveModelKey({ infmax_model_prefix: 'glm5.1' })).toBe('glm5.1');
expect(resolveModelKey({ infmax_model_prefix: 'glm5.2' })).toBe('glm5.2');
expect(resolveModelKey({ infmax_model_prefix: 'kimik2.6' })).toBe('kimik2.6');
expect(resolveModelKey({ infmax_model_prefix: 'minimaxm2.7' })).toBe('minimaxm2.7');
expect(resolveModelKey({ model: 'amd/GLM-5.1-MXFP4' })).toBe('glm5.1');
expect(resolveModelKey({ model: 'zai-org/GLM-5.2-FP8' })).toBe('glm5.2');
});
});

Expand Down
1 change: 1 addition & 0 deletions packages/db/src/etl/normalizers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export const MODEL_TO_KEY: Record<string, string> = {
// GLM-5
'zai-org/GLM-5-FP8': 'glm5',
'amd/GLM-5.1-MXFP4': 'glm5.1',
'zai-org/GLM-5.2-FP8': 'glm5.2',
// DeepSeek-V4-Pro
'deepseek-ai/DeepSeek-V4-Pro': 'dsv4',
};
Expand Down
Loading