Skip to content

[LMCache] Add LMCache configs for dsv4 vllm b200/b300 agentix setups#2153

Open
ApostaC wants to merge 15 commits into
mainfrom
lmcache/agentix
Open

[LMCache] Add LMCache configs for dsv4 vllm b200/b300 agentix setups#2153
ApostaC wants to merge 15 commits into
mainfrom
lmcache/agentix

Conversation

@ApostaC

@ApostaC ApostaC commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adding LMCache configurations for dsv4-vllm launching script
  • Adding 2 nvidia configs with lmcache agentix

Signed-off-by: ApostaC <yihua98@uchicago.edu>
Signed-off-by: ApostaC <yihua98@uchicago.edu>
@cquil11 cquil11 added the agentx AgentX benchmarks, recipes, and infrastructure label Jul 10, 2026 — with ChatGPT Codex Connector
ApostaC added a commit that referenced this pull request Jul 10, 2026
…ntry

Resolve the perf-changelog.yaml tail conflict with #2127 per KLAUD_DEBUG.md §1.1:
take main's changelog wholesale and re-append this PR's entry at the end, with
pr-link updated from the XXX placeholder to #2153.

中文:将 origin/main 合并到 lmcache/agentix,按 KLAUD_DEBUG.md §1.1 处理
perf-changelog.yaml 末尾冲突:整体采用 main 的版本并在末尾重新追加本 PR 的
条目,同时把 pr-link 占位符更新为 #2153。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional findings (outside current diff — PR may have been updated during review):

  • 🟡 perf-changelog.yaml:4720-4727 — PR title and description are English-only, but AGENTS.md requires bilingual PR metadata: title format <English title> / <中文标题> and a ## 中文说明 section in the body mirroring the English summary. Please update the title (e.g. append / [LMCache] 为 dsv4 vllm b200/b300 agentix 配置添加 LMCache) and add a ## 中文说明 section to the description before merge.

    Extended reasoning...

    AGENTS.md line 7 states: "PR and GitHub-issue titles & descriptions must be bilingual — include a Simplified Chinese version in addition to English. Title format: ' / <中文标题>'. In the PR/issue body, follow the English content with its Chinese translation (e.g. a '## 中文说明' section mirroring the summary)." This is a repo-wide convention that applies to every PR.

    The PR under review is missing both required pieces:

    • Title: [LMCache] Add LMCache configs for dsv4 vllm b200/b300 agentix setups — English only, no / <中文标题> suffix.
    • Body: two English bullets under # Summary ("Adding LMCache configurations for dsv4-vllm launching script" / "Adding 2 nvidia configs with lmcache agentix") with no ## 中文说明 section following them.

    Step-by-step proof of the violation:

    1. Open AGENTS.md at line 7 — the bilingual rule is explicit and unambiguous, with the exact title format and the ## 中文说明 section pattern spelled out.
    2. Read the PR title as rendered on GitHub — it contains only ASCII characters and no / separator introducing a Chinese portion.
    3. Read the PR body — the entire description is 3 lines of English (# Summary header plus two bullets); grep for 中文说明 in the body returns nothing.
    4. Therefore both required bilingual elements are absent, directly violating the rule at AGENTS.md:7.

    Impact: This is metadata-only — the benchmark scripts and configs themselves are unaffected, CI will still run, and no runtime behavior changes. But the repo convention exists so that non-English speakers on the team can review and search PR history, and every merged PR sets precedent. The rule is stated as a requirement, not a suggestion.

    How to fix (no code change needed):

    1. Edit the PR title to append a Chinese translation after /, e.g. [LMCache] Add LMCache configs for dsv4 vllm b200/b300 agentix setups / [LMCache] 为 dsv4 vllm b200/b300 agentix 配置添加 LMCache.
    2. Add a ## 中文说明 section to the PR body after the English summary, mirroring the two bullets — for example:
      ## 中文说明
      - 为 dsv4-vllm 启动脚本添加 LMCache 配置
      - 新增 2 个使用 LMCache agentix 的 NVIDIA 配置
      

    Severity is nit — this is a documentation/metadata policy issue, easy to fix in the PR description with no code impact, but should be addressed before merge since AGENTS.md declares it a requirement.

Comment thread benchmarks/single_node/agentic/dsv4_fp4_b200_vllm.sh
Comment thread perf-changelog.yaml Outdated
…ntry

Signed-off-by: ApostaC <yihua98@uchicago.edu>
@github-actions

Copy link
Copy Markdown
Contributor

ApostaC added a commit that referenced this pull request Jul 10, 2026
Bring-up on PR #2153 showed full-budget pinned pools OOM-killing B200 nodes
(host OOM-killer / cudaErrorMemoryAllocation) as the LMCache lazy allocator
filled past ~2 TB, so cap --l1-size-gb at 75% of TOTAL_CPU_DRAM_GB. Run the
LMCache section on vllm/vllm-openai:v0.24.0 (the LMCache-0.5.x-validated
pairing) with the CUTLASS DSL cu13 reinstall gated to vLLM < 0.24, and drop
the B300 LMCache section for now to focus test runs on B200.

中文:PR #2153 启动调试发现满预算固定内存池会在缓存填充超过约 2 TB 时触发
节点 OOM(主机 OOM-killer / cudaErrorMemoryAllocation),故将 --l1-size-gb
上限降至 TOTAL_CPU_DRAM_GB 的 75%。LMCache 配置改用 vllm/vllm-openai:v0.24.0
镜像(与 LMCache 0.5.x 验证过的组合),CUTLASS DSL cu13 重装仅在 vLLM < 0.24
时执行;暂时移除 B300 的 LMCache 配置,将测试集中在 B200。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Comment on lines +73 to +77
# The v0.24 images ship fixed bindings; reinstalling there would downgrade.
VLLM_INSTALLED_VERSION=$(python3 -c "from importlib.metadata import version; print(version('vllm'))")
if [ "$(printf '%s\n' "$VLLM_INSTALLED_VERSION" 0.24.0 | sort -V | head -n1)" != "0.24.0" ]; then
agentic_pip_install --quiet --force-reinstall --no-deps \
'nvidia-cutlass-dsl-libs-cu13==4.5.2'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally we don't allow reinstalling kernel libraries

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@functionstackx functionstackx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @ApostaC

can u please update recipes.vllm.ai with ur new configs? https://github.com/vllm-project/recipes

vllm recipes doesn't currently support offloading tho the inferact guys said they are open to contributions to support mooncake store, lmcache, vllm native offloading support in vllm recipes

as in sglang cookbook recipes , they also have support for cpu offloading recipes

Image

ApostaC added 2 commits July 10, 2026 15:37
Signed-off-by: ApostaC <yihua98@uchicago.edu>
Signed-off-by: ApostaC <yihua98@uchicago.edu>
@github-actions

Copy link
Copy Markdown
Contributor

agentic_pip_install --quiet --no-cache-dir --no-deps \
--force-reinstall "mooncake-transfer-engine-cuda13==$MOONCAKE_VERSION"
python3 -c "from mooncake.store import MooncakeDistributedStore" >/dev/null
python3 "$(dirname "$0")/patch_vllm_pr45406.py"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally we wanna avoid patches too

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is what I picked from #2138. Once that is in, I will remove this.

@github-actions

Copy link
Copy Markdown
Contributor

Signed-off-by: ApostaC <yihua98@uchicago.edu>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

ApostaC added 2 commits July 11, 2026 14:06
Signed-off-by: ApostaC <yihua98@uchicago.edu>
Signed-off-by: ApostaC <yihua98@uchicago.edu>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Signed-off-by: ApostaC <yihua98@uchicago.edu>
@github-actions

Copy link
Copy Markdown
Contributor

Signed-off-by: ApostaC <yihua98@uchicago.edu>
@github-actions

Copy link
Copy Markdown
Contributor

Comment on lines -184 to -188
# AgentX concurrency counts live session trees, not individual requests.
# Subagent fan-out can push instantaneous request concurrency above CONC, so
# leave 2x headroom rather than clipping those bursts at the scheduler.
MAX_NUM_SEQS=$((2 * CONC))

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being moved to the top of the script

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentx AgentX benchmarks, recipes, and infrastructure full-sweep-enabled

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants