Repository navigation
fix(sendspin-dotnet adapter): report the negotiated stream in server-initiated cases - #146
Merged
chrisuthe merged 1 commit intoOct 7, 2026
Conversation
…initiated cases The listener path never subscribed to stream/start, so server-initiated cases reported stream as null and format-dependent checks had nothing to judge. Subscribe on the host service, as the outbound path does on the client. peer_hello stays null on this path: Sendspin.SDK 10.0.0 exposes no raw server/hello frame, and its ServerHelloPayload carries server_id, version and active_roles values that were not in that frame.
There was a problem hiding this comment.
🟢 Approval recommended
The listener now uses the existing shared capture path without changing scenario behavior or assertions.
0 open findings
What changed in this PR
Ensures the .NET client adapter records negotiated streams for server-initiated connections.
Changes:
- Subscribes the listener host to
StreamStartReceived. - Documents why listener-path
peer_helloremains unavailable.
| File | Description |
|---|---|
adapters/sendspin-dotnet/client/Program.cs |
Captures listener-path stream negotiation details. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The .NET client adapter reported
streamasnullin every server-initiated case. The listener path never subscribed tostream/start; the outbound path did. This subscribes on the host service, so both paths report the negotiated stream in the same shape.Evidence
aiosendspin server → sendspin-dotnet client,
client-summary.json, before and after:streambeforestreamafterserver-initiated-pcmnull{"codec":"pcm","sample_rate":8000,"channels":1,"bit_depth":16}server-initiated-pcm-24bitnull{"codec":"pcm","sample_rate":8000,"channels":1,"bit_depth":16}server-initiated-flacnull{"codec":"flac","sample_rate":8000,"channels":1,"bit_depth":16,"codec_header":"ZkxhQ4…"}server-initiated-audio-chunk-framingnull{"codec":"pcm","sample_rate":8000,"channels":1,"bit_depth":16}server-initiated-artworknull{"channels":[{"source":"album","format":"jpeg","width":256,"height":256}]}Metadata and controller cases receive no
stream/startand still reportnull.Cell status
No cell changes status: 10 of 16 pass before and after, the same ten.
server-initiated-flacstill passes, and its reason gains the header check now that the client reports one: "FLAC header and chunk bytes match exactly and the decoded audio matches the source clip".server-initiated-pcm-24bitstill passes, but the summary now shows why that pass says nothing about 24-bit: the server's source is 24-bit and the negotiated stream is 16-bit. No assertion reads the negotiated depth yet, so the cell stays green. Nothing was softened or flagged.peer_hellostaysnullon the listener pathSendspin.SDK 10.0.0 has no public accessor for the raw
server/helloframe (sendspin-go hasRawServerHello()). ItsServerHelloPayloadcannot stand in for the frame:server_id: ""andversion: 1are property defaults, andactive_rolesis copied in from the laterserver/activate. Reporting it would present SDK state as what the server sent, so the inbound hello is left unobserved.The outbound path already reports that object, flat rather than as a
{type, payload}envelope. It is left as is here and needs the same accessor to fix properly.Verification
dotnet buildof the adapter: 0 errorspython -m unittest discover -s tests: 344 passpython -m conformance.cli reportrendersSendspin/sendspin-dotnetmain(0d97454), aiosendspin90cecf2No
scenario_revisionbump: no scenario's stimulus or assertions change.