Skip to content

increase timeout indefinetely in agentlab-mentor #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

increase timeout indefinetely in agentlab-mentor #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agentlab/agents/hitl_agent/generic_human_guided_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def get_action(self, obs):
)

self.ui.update_context(hint_labeling_inputs)
response = self.ui.wait_for_response(timeout=600)
response = self.ui.wait_for_response(timeout=None)

if response["type"] == "reprompt":
new_hints = response["payload"].get("hints", [])
Expand Down
2 changes: 1 addition & 1 deletion src/agentlab/agents/hitl_agent/hitl_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def get_action(self, obs):
)

self.ui.update_context(hint_labeling_inputs)
response = self.ui.wait_for_response(timeout=600)
response = self.ui.wait_for_response(timeout=None)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infinite Wait Vulnerability category Security

Tell me more
What is the issue?

The timeout for the UI response wait has been changed from 600 seconds to None, effectively removing the timeout limit.

Why this matters

Without a timeout limit, the application becomes vulnerable to potential Denial of Service (DoS) attacks where a malicious user could intentionally hang the system indefinitely by never providing a response.

Suggested change ∙ Feature Preview
response = self.ui.wait_for_response(timeout=600)  # Or another reasonable timeout value
Provide feedback to improve future suggestions

Nice Catch Incorrect Not in Scope Not in coding standard Other

💬 Looking for more details? Reply to this comment to chat with Korbit.


if response["type"] == "reprompt":
new_hints = response["payload"].get("hints", [])
Expand Down
Loading