fix: preserve fractional block volume - #12
Open
nvphungdev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The block list was converting
total_out + subsidyfrom satoshis to BGL and then applyingparseInt, followed by a zero-decimal BGL formatter. Current Bitgesell block amounts can be below 1 BGL, so valid blockstats values were displayed as0.Closes #11
Validation
npm testviews/includes/blocks-list.pugwith mocked blockstats where subsidy is 596 sats and confirmed the volume cell renders fractional BGL instead of 0git diff --checkNote:
npm run lintstill reports existing unrelated errors acrossapp/androutes/; this PR only changes the Pug block-list template.