fix: remove unused variable in test_benchmarks.py #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the unused `result` variable assignment in the test_custom_progress_callback function. The test only needs to verify callback invocations, not the return value. This fixes the ruff F841 linting error that was causing CI failures.
Applied ruff formatting to 8 files that were not properly formatted: - benchmarks/runner.py - examples/oolong_example.py - examples/subprocess_repl_demo.py - rlm/environments/subprocess_repl.py - tests/clients/test_huggingface.py - tests/environments/test_subprocess_repl.py - tests/test_exceptions.py - tests/test_registry.py This ensures the codebase passes CI formatting checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unused
resultvariable assignment in thetest_custom_progress_callback function. The test only needs to verify
callback invocations, not the return value.
This fixes the ruff F841 linting error that was causing CI failures.