forked from SVG-Edit/svgedit
-
Notifications
You must be signed in to change notification settings - Fork 1
Merge changes from source repo and do rollup in Dockerfile #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se in svgCanvas.svgToString() (SVG-Edit#1051)
* Update history.js - Change `BatchCommand.unapply` to use `[...this.commands].reverse()` so the original array is never mutated. - This preserves the order of commands and ensures history integrity.
9 tasks
jaydeepsingh25
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
This step makes the build process occur within this repo which is ideal as there were cases in the past where changes in dependencies would install but not properly build on docker (but the build only occurred in the IMAGE-server workflow making them harder to test/ identify). With these changes, such failures can be caught and rectified at the first build stage.
These changes were tested by using an override on unicorn along with the changes made in this PR updating the IMAGE TAT service Dockerfile and ensuring that the build works and pushes data correctly to the Monarch with this photo and a hand drawn example.