Skip to content

Conversation

@VenissaCarolQuadros
Copy link
Member

@VenissaCarolQuadros VenissaCarolQuadros commented Jun 5, 2025

Changes have been made to the Dockerfile and test-docker-compose.yml to:

  1. Create an environment variable SERVER_URL in test-docker-compose (SERVER_NAME was not being used and has hence been removed)
  2. Remove hardcoded server urls in Dockerfile. Instead command creates a config.js at run using the environment variable, and this is picked up by the application.

NOTE: Please merge this PR after Shared-Reality-Lab/IMAGE-TactileAuthoring#15 is merged.

TESTING:
Tested that the tat is able to update content to the correct server based on the environment variable value SERVER_URL using override (tested by swapping between prod and dev server urls). The version of tat on IMAGE-TactileAuthoring branch server_url was used for this. docker compose up -d tat --no-build was used to ensure that the image is not rebuilt after when these swaps were made.

Closes #1059


Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue.
  • I described how I tested these changes.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@jaydeepsingh25 jaydeepsingh25 merged commit bccf73b into main Jun 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove hardcoding and standardize Monarch tool/service endpoint URLs

3 participants