Skip store publishing steps unless all required secrets are set#18
Merged
ShiosOS merged 4 commits intoJul 14, 2026
Conversation
…higher bar (#15) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
) Both steps are gated on their secrets being configured, so the workflow keeps producing a plain GitHub Release until AMO_JWT_ISSUER/SECRET and the CWS_* secrets are added. With secrets present, the .xpi attached to the release is the Mozilla-signed (unlisted channel) file, and the .zip is uploaded to the Chrome Web Store and submitted for publication. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Julius Walton <ShiosOS@users.noreply.github.com>
…re set Co-authored-by: Julius Walton <ShiosOS@users.noreply.github.com>
ShiosOS
marked this pull request as ready for review
July 14, 2026 18:36
…s skip conditions Co-authored-by: Julius Walton <ShiosOS@users.noreply.github.com>
ShiosOS
merged commit Jul 14, 2026
1e77cc1
into
cursor/store-publish-automation-1cf5
7 checks passed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7eca596. Configure here.
| // name that itself contains a standalone status word (e.g. "error-pages") | ||
| // is still ambiguous — labels are all GitHub's accessible rows give us. | ||
| const FAILING_RE = | ||
| /\b(fail(?:ed|ing|ure|s)?|error(?:ed|s)?|timed out|cancel(?:l?ed)?|denied|action required)\b/i; |
There was a problem hiding this comment.
Plural failures not detected
Low Severity
The new word-boundary FAILING_RE no longer treats check row labels that use the plural word failures as failing, whereas the previous substring fail matcher did. The conversation checks indicator can stay passing or unknown when a label only reports failures in that form.
Reviewed by Cursor Bugbot for commit 7eca596. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The store publishing steps in
.github/workflows/release.ymleach gated on only a single secret:AMO_JWT_ISSUER, but theweb-ext signcommand also requiresAMO_JWT_SECRET.CWS_EXTENSION_ID, but the upload also requiresCWS_CLIENT_ID,CWS_CLIENT_SECRET, andCWS_REFRESH_TOKEN.If a repo configured some but not all of a store's secrets, the step still ran, failed against the store API, and aborted the job before the "Create GitHub Release" step — breaking the graceful degradation to a plain GitHub Release that the workflow comments promise.
Fix
Each
ifcondition now requires all of that store's secrets to be non-empty, so a partially configured store is skipped instead of failing the release.Verification
@action-validator/cli.