Dismiss checkout on receipt of unrecoverable severity error#153
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kiftio
force-pushed
the
05-19-parse_all_error_messages
branch
from
f0930b1 to
46190cc
Compare
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
3 times, most recently
from
363462b to
ef4d437
Compare
Web — Coverage Report
|
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
from
ef4d437 to
ab99908
Compare
kiftio
force-pushed
the
05-19-parse_all_error_messages
branch
2 times, most recently
from
0e821b5 to
587d706
Compare
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
from
ab99908 to
157a83e
Compare
kiftio
changed the base branch from
05-19-parse_all_error_messages
to
graphite-base/153
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
from
157a83e to
cefdac4
Compare
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
from
cefdac4 to
d08ea1b
Compare
React Native — Coverage Report
|
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
from
d08ea1b to
0a45550
Compare
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
4 times, most recently
from
31f61de to
42af96d
Compare
kiftio
changed the title
kiftio
force-pushed
the
05-19-dismiss_on_unrecoverable
branch
from
42af96d to
a254df1
Compare
kieran-osgood-shopify
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Close checkout when we receive
ec.errorfrom checkout withseverityset tounrecoverable, in addition to emitting theon(CheckoutProtocol.error) {}callback.As we may receive multiple errors, we'll close when we find any of those errors have that severity
CONTRIBUTES TO https://github.com/shop/issues-checkout-kit/issues/935
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.