Skip to content

updates the delegation log for clarity#180

Merged
kiftio merged 1 commit into
mainfrom
update-delegation-log-for-clarity
May 21, 2026
Merged

updates the delegation log for clarity#180
kiftio merged 1 commit into
mainfrom
update-delegation-log-for-clarity

Conversation

@kiftio

@kiftio kiftio commented May 21, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Looking to update something that caused me a bit of confusion.

We previously logged checkout accepted delegations as requestedDelegations, where I think of these as those delegations we include in the request URL's query params. And then we logged accepted delegations as those filtered by our own kit supported delegations.

So looking to clarify things a bit here with:

  • checkoutAcceptedDelegations
  • checkoutKitSupportedDelegations
  • negotiatedDelegations

How to test

n/a

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kiftio kiftio requested a review from a team as a code owner May 21, 2026 10:58
@github-actions

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 95%
95.43% (188/197) 92.17% (106/115) 100% (60/60)

@tiagocandido tiagocandido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that Dan! Much clearer!

@kiftio kiftio merged commit d584cab into main May 21, 2026
22 checks passed

kiftio commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

@kiftio kiftio deleted the update-delegation-log-for-clarity branch May 21, 2026 11:10
@kiftio kiftio added the #gsd:50662 Rebase Checkout Kit on UCP label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants