fix "dev swift fix" command#231
Open
markmur wants to merge 1 commit into
Open
Conversation
React Native — Coverage Report
|
kiftio
reviewed
May 28, 2026
| # Run from the directory containing .swiftlint.yml so its `included:` paths | ||
| # resolve consistently. | ||
| PROJECT_ROOT="$(git rev-parse --show-toplevel 2>/dev/null || pwd)" | ||
| if [[ "$MODE" == "fix" ]]; then |
Contributor
There was a problem hiding this comment.
did you say there was a second config file we could clean up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Changed platforms/swift/Scripts/lint to run SwiftLint fix from the repo root, matching the strict pass and making root .swiftlint.yml path handling consistent. Also changed SwiftFormat to run only over Sources Tests so it no longer formats Samples, matching the root SwiftLint.
Simplified platforms/swift/.swiftformat by removing exclusions that are now unnecessary because SwiftFormat no longer scans those directories.
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.