Await checkout bridge JavaScript evaluation#250
Closed
kieran-osgood-shopify wants to merge 1 commit into
Closed
Conversation
React Native — Coverage Report
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/checkout-bridge/evaluate-js-completion
branch
from
9d5c7ef to
4e422ba
Compare
kieran-osgood-shopify
changed the title
Contributor
|
After discussing, we're going to remove this code in #251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Await
WKWebView.evaluateJavaScriptwhen dispatching checkout bridge messages.CheckoutBridge.sendMessage(_ webView:...)now uses the async WebKit API and returns whether evaluation completed successfully. Failures are logged and returned asfalse.For the presented event,
CheckoutWebViewtracks an in-flight dispatch and only markspresentedEventDidDispatchafter JavaScript evaluation completes successfully. This avoids treating the event as dispatched before WebKit has actually evaluated it.The tests now await the production
sendMessage(_ webView:...)entrypoint directly, avoiding the previous async XCTest expectation without adding a test-onlysendMessageoverload.How to test
dev swift test CheckoutBridgeTestsdev swift test CheckoutWebViewTestsBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.