Skip to content

fix ec.error shape in web platform#255

Open
kiftio wants to merge 1 commit into
mainfrom
fix-ec-error
Open

fix ec.error shape in web platform#255
kiftio wants to merge 1 commit into
mainfrom
fix-ec-error

Conversation

@kiftio
Copy link
Copy Markdown
Contributor

@kiftio kiftio commented Jun 3, 2026

What changes are you making?

  • Update web ec.error handling to match the Swift/Android protocol shape: params.error.
  • Add explicit EcErrorParams typing for the raw JSON-RPC params envelope.
  • Reject the old invalid ec.error shape where ucp and messages are directly under params.
  • Update tests to send valid ec.error params via makeErrorParams() and keep a regression test for the old shape.

How to test

  • pnpm --dir platforms/web run format:check
  • pnpm --dir platforms/web run typecheck
  • shadowenv exec --dir /Users/danielkift/ck -- /opt/dev/bin/dev web test
  • git diff --check

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kiftio kiftio requested a review from a team as a code owner June 3, 2026 17:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
98.82% (252/255) 88.43% (130/147) 100% (55/55)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant