Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some initial code for showing authentication with new customer accounts #212

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kiftio
Copy link
Contributor

@kiftio kiftio commented Sep 2, 2024

What changes are you making?

Includes:

  • launching a login page webview
  • handling the auth code redirect
  • completing the OAuth authorization code with pkce exchange

Doesn't yet include:

  • Storing tokens securely
  • Refresh token requests
  • Attaching obtained tokens to cart mutations
  • Can we render new customer accounts login in dark mode?

(Possibly not all idiomatic swift)

How to test


Before you merge

Important


Checklist for releasing a new version
  • I have bumped the version number in the podspec file.
  • I have bumped the version number in the README.
  • I have added a Changelog entry.

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@tiagocandido tiagocandido force-pushed the dk/wip-nca-auth branch 3 times, most recently from fd1336a to 81e8b4b Compare November 11, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants