Skip to content

[Tests] Add unit tests for deprecations store - #8374

Merged
gonzaloriestra merged 2 commits into
mainfrom
tests-deprecations-store-coverage-2854649748783195092
Sep 23, 2026
Merged

gonzaloriestra merged 2 commits into
mainfrom
tests-deprecations-store-coverage-2854649748783195092

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

deprecations-store.ts in @shopify/cli-kit manages state for the earliest upcoming deprecation date across CLI calls, but previously lacked unit tests.

WHAT is this pull request doing?

Adds unit tests in packages/cli-kit/src/private/node/context/deprecations-store.test.ts covering getNextDeprecationDate and setNextDeprecationDate:

  • Verifies default undefined state
  • Handles empty date arrays and past dates
  • Sets the earliest future deprecation date when provided multiple dates
  • Updates stored date when a newer date is earlier, and preserves existing date when new dates are later

How to test your changes?

CI

Post-release steps

N/A

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 2854649748783195092 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@gonzaloriestra gonzaloriestra added Jules Created by Jules and removed no-pr-activity labels Sep 22, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review September 22, 2026 09:03
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner September 22, 2026 09:03
@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit e9c59e5 Sep 23, 2026
30 of 31 checks passed
@gonzaloriestra
gonzaloriestra deleted the tests-deprecations-store-coverage-2854649748783195092 branch September 23, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants