Skip to content

Handle invalid remote contract schemas - #8391

Closed
dmerand wants to merge 1 commit into
mainfrom
contract-hardening-normalization-fallback
Closed

dmerand wants to merge 1 commit into
mainfrom
contract-hardening-normalization-fallback

Conversation

@dmerand

@dmerand dmerand commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

A malformed or invalid remote contract JSON Schema served by the platform must not abort CLI commands.

WHAT is this pull request doing?

  • Fall back to merged.parseConfigurationObject unchanged when the remote schema cannot normalize or compile.
  • Omit a remote-only specification only when its schema cannot normalize. getArrayRejectingUndefined removes the resulting undefined; valid remote-only specifications remain.
  • Warn once per parser instance or specification fetch. app dev reloads reuse app.specifications, so reloads do not warn again. A new CLI invocation can warn again.
  • Keep server-side validation authoritative.

Assisted-By: devx/533b856c-5f30-42c9-8965-a066782729a4
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Aug 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues no-pr-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant