Repository navigation
Normalize subscription migration scheduling JSON - #8587
Merged
gonzaloriestra merged 5 commits intoOct 9, 2026
Merged
gonzaloriestra merged 5 commits into
gonzaloriestra merged 5 commits into
Conversation
4 tasks done
gonzaloriestra
added this pull request to stack #8590
September 18, 2026 12:23
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
September 21, 2026 12:17
8b7438e to
f733c40
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
3 times, most recently
from
September 24, 2026 10:32
2fb86a1 to
c1274ae
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
September 24, 2026 10:41
c1274ae to
76ac9ea
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 10:46
gonzaloriestra
marked this pull request as draft
October 6, 2026 12:00
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
October 6, 2026 12:05
76ac9ea to
18064b5
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
October 6, 2026 12:26
18064b5 to
2dccbb2
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 08:57
isaacroldan
reviewed
Oct 8, 2026
isaacroldan
left a comment
Contributor
There was a problem hiding this comment.
One issue with the text error output.
🤖 Generated by the review-pr skill
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
October 8, 2026 11:40
2dccbb2 to
7850840
Compare
isaacroldan
approved these changes
Oct 8, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
October 9, 2026 07:45
7850840 to
1938e48
Compare
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gonzaloriestra
force-pushed
the
gonzalo/json-subscription-migrations-schedule
branch
from
October 9, 2026 08:12
1938e48 to
c6d89fa
Compare
Contributor
|
| Changeset | Package |
|---|---|
normalize-migration-submission-json.md |
"@shopify/cli": major |
normalize-migration-subscription-list-json.md |
"@shopify/cli": major |
normalize-subscription-migration-json.md |
"@shopify/cli": major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/public/node/error/serialization.d.tsimport type { JsonError } from './types.js';
/**
* Projects an error into the shared JSON error contract, retaining only allowlisted fields.
*
* @param source - Error to project.
* @returns The error classification, message, and available recovery information.
*/
export declare function errorToJson(source: unknown): JsonError;
Existing type declarationspackages/cli-kit/dist/private/node/json-error.d.ts@@ -1,16 +1,3 @@
-interface FatalErrorLike {
- type?: number;
- message?: unknown;
- formattedMessage?: unknown;
- tryMessage?: unknown;
- nextSteps?: unknown;
- customSections?: unknown;
- stack?: unknown;
- command?: unknown;
- args?: unknown;
- details?: unknown;
- code?: unknown;
-}
/**
* Writes the public JSON representation of a fatal error to stdout.
*
@@ -19,5 +6,4 @@ interface FatalErrorLike {
*
* @param error - Fatal error to serialize.
*/
-export declare function renderFatalErrorAsJson(error: FatalErrorLike): void;
-export {};
\ No newline at end of file
+export declare function renderFatalErrorAsJson(error: unknown): void;
\ No newline at end of file
|
gonzaloriestra
deleted the
gonzalo/json-subscription-migrations-schedule
branch
October 9, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Subscription migration JSON must follow the shared CLI conventions and expose a discoverable contract.
WHAT is this pull request doing?
Use
statusandchanged,gid/shopGidandoperationGidsfields, flat results, andfieldPathdiagnostics. Preserve accepted work on partial failure; declined confirmation exits zero with a cancellation result and failures without accepted work use the shared fatal error envelope. RemoveschemaVersion; result contracts follow CLI release versions. Update the schema, tests, and generated help together. These existing JSON contract changes include a major changeset.How to manually test your changes?
Checklist