Repository navigation
Add typed JSON output to theme duplicate - #8640
Open
gonzaloriestra wants to merge 5 commits into
Open
gonzaloriestra wants to merge 5 commits into
gonzaloriestra wants to merge 5 commits into
Conversation
gonzaloriestra
added this pull request to stack #8654
September 24, 2026 09:47
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 24, 2026 10:04
d0ed9ba to
c3e4082
Compare
gonzaloriestra
removed this pull request from stack #8654
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
main
to
gonzalo/json-theme-open
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 24, 2026 10:13
c3e4082 to
827589c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 24, 2026 10:25
827589c to
25b84a6
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 24, 2026 11:56
25b84a6 to
af1f31c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 24, 2026 13:46
af1f31c to
79c0066
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:12
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 24, 2026 14:36
79c0066 to
d1a063b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 25, 2026 12:27
d1a063b to
5c39b71
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
September 28, 2026 08:20
5c39b71 to
e67fd64
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
2 times, most recently
from
September 28, 2026 11:39
be76aef to
b0ed722
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 6, 2026 12:29
a7fafbf to
794fd87
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 6, 2026 12:31
794fd87 to
675cea7
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 6, 2026 13:53
675cea7 to
36d8e30
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 8, 2026 08:43
36d8e30 to
04cbc97
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 8, 2026 09:53
04cbc97 to
a95492b
Compare
gonzaloriestra
marked this pull request as ready for review
October 8, 2026 10:04
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 9, 2026 12:00
a95492b to
591e909
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 9, 2026 12:26
591e909 to
09f3bdf
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 9, 2026 12:48
09f3bdf to
9d6380a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 9, 2026 13:09
9d6380a to
3333906
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-duplicate
branch
from
October 9, 2026 13:19
3333906 to
2ce0e00
Compare
Contributor
|
| Changeset | Package |
|---|---|
theme-duplicate-json-contract.md |
'@shopify/cli': major |
theme-info-json-contract.md |
'@shopify/cli': major |
theme-list-json-contract.md |
'@shopify/cli': major |
theme-open-json-contract.md |
'@shopify/cli': major |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Theme duplication needs a stable automation result and explicit cancellation.
WHAT is this pull request doing?
Expose strict string-ID theme resources with status and changed, return cancellation objects, and route failed operations through the shared fatal envelope. Retain all explicit environment results.
The public output follows
docs/cli/json-output.md; explicitly named environments use one{environments: [...]}object.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add