Skip to content

Add typed JSON output to theme duplicate - #8640

Open
gonzaloriestra wants to merge 5 commits into
gonzalo/json-theme-openfrom
gonzalo/json-theme-duplicate
Open

gonzaloriestra wants to merge 5 commits into
gonzalo/json-theme-openfrom
gonzalo/json-theme-duplicate

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Theme duplication needs a stable automation result and explicit cancellation.

WHAT is this pull request doing?

Expose strict string-ID theme resources with status and changed, return cancellation objects, and route failed operations through the shared fatal envelope. Retain all explicit environment results.

The public output follows docs/cli/json-output.md; explicitly named environments use one {environments: [...]} object.

How to manually test your changes?

shopify theme duplicate --theme <theme-id> --store example.myshopify.com --json
shopify theme duplicate --json-schema

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

@gonzaloriestra gonzaloriestra changed the title gonzalo/json theme duplicate Add typed JSON output to theme duplicate Sep 24, 2026
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Sep 24, 2026
@gonzaloriestra
gonzaloriestra added this pull request to stack #8654 September 24, 2026 09:47
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from d0ed9ba to c3e4082 Compare September 24, 2026 10:04
@gonzaloriestra
gonzaloriestra removed this pull request from stack #8654 September 24, 2026 10:04
@gonzaloriestra
gonzaloriestra changed the base branch from main to gonzalo/json-theme-open September 24, 2026 10:05
@gonzaloriestra
gonzaloriestra added this pull request to stack #8655 September 24, 2026 10:05
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from c3e4082 to 827589c Compare September 24, 2026 10:13
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 827589c to 25b84a6 Compare September 24, 2026 10:25
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Sep 24, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 25b84a6 to af1f31c Compare September 24, 2026 11:56
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from af1f31c to 79c0066 Compare September 24, 2026 13:46
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review September 24, 2026 14:12
@gonzaloriestra
gonzaloriestra requested review from a team as code owners September 24, 2026 14:12
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 79c0066 to d1a063b Compare September 24, 2026 14:36
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from d1a063b to 5c39b71 Compare September 25, 2026 12:27
@gonzaloriestra
gonzaloriestra removed this pull request from stack #8655 September 25, 2026 12:28
@gonzaloriestra
gonzaloriestra added this pull request to stack #8673 September 25, 2026 12:29
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 5c39b71 to e67fd64 Compare September 28, 2026 08:20
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch 2 times, most recently from be76aef to b0ed722 Compare September 28, 2026 11:39
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from a7fafbf to 794fd87 Compare October 6, 2026 12:29
@github-actions github-actions Bot added Area: @shopify/cli @shopify/cli package issues and removed no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. labels Oct 6, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 794fd87 to 675cea7 Compare October 6, 2026 12:31
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 675cea7 to 36d8e30 Compare October 6, 2026 13:53
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 36d8e30 to 04cbc97 Compare October 8, 2026 08:43
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 04cbc97 to a95492b Compare October 8, 2026 09:53
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review October 8, 2026 10:04
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from a95492b to 591e909 Compare October 9, 2026 12:00
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 591e909 to 09f3bdf Compare October 9, 2026 12:26
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 09f3bdf to 9d6380a Compare October 9, 2026 12:48
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 9d6380a to 3333906 Compare October 9, 2026 13:09
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/json-theme-duplicate branch from 3333906 to 2ce0e00 Compare October 9, 2026 13:19
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Potential Breaking Changes Detected

This PR contains changes that may break the existing contract.

@shopify/dev_experience — this PR contains breaking changes that require coordination for the next major release.

📦 Major Version Changesets

The following changesets request a major version bump:

Changeset Package
theme-duplicate-json-contract.md '@shopify/cli': major
theme-info-json-contract.md '@shopify/cli': major
theme-list-json-contract.md '@shopify/cli': major
theme-open-json-contract.md '@shopify/cli': major

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/base-command.d.ts
@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
         argv: string[];
     }>;
     protected environmentsFilename(): string | undefined;
+    protected validateNonTTYFlags(flags: FlagOutput): void;
     protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
     private failMissingNonTTYFlagRequirements;
     private applicableNonTTYFlagRequirements;

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants